Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add full Python 3 tests to Travis CI #29360

Closed
wants to merge 4 commits into from

Conversation

@cclauss
Copy link
Contributor

commented Aug 28, 2019

This PR significantly reduces our Travis CI build times and provides better test coverage.

Remove the former, incomplete Travis CI runs on Python 3.6 and 3.7 and replace them with the full 5 stage pipeline running on both Python 2.7 and 3.6.

The Python 3.6 tests pass all runs except Test C++ Suites (py3) as discussed in #29246 and the Python 3.6 run can be replaced with a Python 3.7 run when #29346 or similar has landed.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@cclauss cclauss changed the title Add py3 to travis ci build: add full Python 3 tests to Travis CI Aug 28, 2019

@cclauss cclauss force-pushed the cclauss:add-py3-to-travis-ci branch from 2ee4c12 to 736ec33 Aug 28, 2019

@cclauss cclauss added the python label Aug 28, 2019

@cclauss cclauss requested a review from Trott Aug 28, 2019

.travis.yml Outdated Show resolved Hide resolved
.travis.yml Outdated Show resolved Hide resolved
@cclauss

This comment has been minimized.

Copy link
Contributor Author

commented Aug 29, 2019

Does the output of Compile V8 (py2) overwrite the output of Compile V8 (py3) (or vise-versa)?

@bnoordhuis

This comment has been minimized.

Copy link
Member

commented Aug 30, 2019

Does the output of Compile V8 (py2) overwrite the output of Compile V8 (py3) (or vise-versa)?

No? Or is that a trick question? :-)

@nodejs-github-bot

This comment has been minimized.

addons:
apt:
update: true

This comment has been minimized.

Copy link
@Trott

Trott Sep 1, 2019

Member

Should the update: true lines should be there in the final result or should that last commit (that adds them) be omitted when landing? I'm guessing they should be there but I'm asking anyway because the commit message suggests it might be temporary--"Force a retest"--and the Travis docs mildly discourage its use.

This comment has been minimized.

Copy link
@cclauss

cclauss Sep 1, 2019

Author Contributor

I think they can stay in. I believe that the Travis docs are discouraging upgrade vs. update.

Trott added a commit to Trott/io.js that referenced this pull request Sep 1, 2019
build: add full Python 3 tests to Travis CI
PR-URL: nodejs#29360
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: David Carlier <devnexen@gmail.com>
@Trott

This comment has been minimized.

Copy link
Member

commented Sep 1, 2019

Landed in c602b0a

@Trott Trott closed this Sep 1, 2019

@cclauss cclauss deleted the cclauss:add-py3-to-travis-ci branch Sep 1, 2019

bnoordhuis added a commit to bnoordhuis/io.js that referenced this pull request Sep 2, 2019
Revert "build: add full Python 3 tests to Travis CI"
Reverted for breaking the Travis CI builds with the following error:

    $ cp ${PYTHON2_CACHE}/node out/Release/node

    cp: cannot stat '/home/travis/.ccache/py2.7.15/node': No such file
    or directory

    The command "cp ${PYTHON2_CACHE}/node out/Release/node" failed and
    exited with 1 during .

This reverts commit c602b0a.

Refs: nodejs#29360
Trott added a commit to Trott/io.js that referenced this pull request Sep 3, 2019
Revert "build: add full Python 3 tests to Travis CI"
Reverted for breaking the Travis CI builds with the following error:

    $ cp ${PYTHON2_CACHE}/node out/Release/node

    cp: cannot stat '/home/travis/.ccache/py2.7.15/node': No such file
    or directory

    The command "cp ${PYTHON2_CACHE}/node out/Release/node" failed and
    exited with 1 during .

This reverts commit c602b0a.

Refs: nodejs#29360

PR-URL: nodejs#29406
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
BridgeAR added a commit that referenced this pull request Sep 3, 2019
build: add full Python 3 tests to Travis CI
PR-URL: #29360
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: David Carlier <devnexen@gmail.com>
BridgeAR added a commit that referenced this pull request Sep 3, 2019
Revert "build: add full Python 3 tests to Travis CI"
Reverted for breaking the Travis CI builds with the following error:

    $ cp ${PYTHON2_CACHE}/node out/Release/node

    cp: cannot stat '/home/travis/.ccache/py2.7.15/node': No such file
    or directory

    The command "cp ${PYTHON2_CACHE}/node out/Release/node" failed and
    exited with 1 during .

This reverts commit c602b0a.

Refs: #29360

PR-URL: #29406
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
@BridgeAR BridgeAR referenced this pull request Sep 3, 2019
BridgeAR added a commit that referenced this pull request Sep 4, 2019
build: add full Python 3 tests to Travis CI
PR-URL: #29360
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: David Carlier <devnexen@gmail.com>
BridgeAR added a commit that referenced this pull request Sep 4, 2019
Revert "build: add full Python 3 tests to Travis CI"
Reverted for breaking the Travis CI builds with the following error:

    $ cp ${PYTHON2_CACHE}/node out/Release/node

    cp: cannot stat '/home/travis/.ccache/py2.7.15/node': No such file
    or directory

    The command "cp ${PYTHON2_CACHE}/node out/Release/node" failed and
    exited with 1 during .

This reverts commit c602b0a.

Refs: #29360

PR-URL: #29406
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
build: add full Python 3 tests to Travis CI
PR-URL: nodejs#29360
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: David Carlier <devnexen@gmail.com>
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
Revert "build: add full Python 3 tests to Travis CI"
Reverted for breaking the Travis CI builds with the following error:

    $ cp ${PYTHON2_CACHE}/node out/Release/node

    cp: cannot stat '/home/travis/.ccache/py2.7.15/node': No such file
    or directory

    The command "cp ${PYTHON2_CACHE}/node out/Release/node" failed and
    exited with 1 during .

This reverts commit c602b0a.

Refs: nodejs#29360

PR-URL: nodejs#29406
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
build: add full Python 3 tests to Travis CI
PR-URL: nodejs#29360
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: David Carlier <devnexen@gmail.com>
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
Revert "build: add full Python 3 tests to Travis CI"
Reverted for breaking the Travis CI builds with the following error:

    $ cp ${PYTHON2_CACHE}/node out/Release/node

    cp: cannot stat '/home/travis/.ccache/py2.7.15/node': No such file
    or directory

    The command "cp ${PYTHON2_CACHE}/node out/Release/node" failed and
    exited with 1 during .

This reverts commit c602b0a.

Refs: nodejs#29360

PR-URL: nodejs#29406
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.