Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
deps: V8: cherry-pick 597f885 #29367
This backports @schuay's fix in V8 that addresses missing function coverage.
This bug only occurred on certain OSes, and manifested itself as follows:
We now sort functions before applying the optimization of dropping block coverage.
This is difficult to write tests for, because it appears to be architecture dependent but @shuay has been able to confirm the patch (@shuay I don't suppose I could also get you to test against this branch).
Note that we're supposed to get explicit
Not a big deal here, I don't think, but perhaps a sign that we could use a smaller/simpler set of rules and/or more-automated enforcement. (Right now, I think
Yeah, that assumption is a reasonable one and we should probably consider either changing the rule to accommodate that assumption or else finding a way to have