Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: update ESLint to 6.3.0 #29382

Closed
wants to merge 1 commit into from

Conversation

@cjihrig
Copy link
Contributor

commented Aug 30, 2019

Update ESLint to 6.3.0

I'm also going to look into adding the new reportUnusedDisableDirectives to our configuration. We currently rely on passing the --report-unused-disable-directives CLI flag to ESLint in two places. I'm hoping that moving that to the config file could cut the number in half.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
tools: update ESLint to 6.3.0
Update ESLint to 6.3.0
@Trott
Trott approved these changes Aug 30, 2019
Copy link
Member

left a comment

Rubber-stamp LGTM

@trivikr
Copy link
Member

left a comment

RSLGTM

@ZYSzys
ZYSzys approved these changes Sep 1, 2019
Copy link
Member

left a comment

RSLGTM

@ZYSzys ZYSzys added the author ready label Sep 1, 2019

@nodejs-github-bot

This comment has been minimized.

danbev added a commit that referenced this pull request Sep 3, 2019
tools: update ESLint to 6.3.0
Update ESLint to 6.3.0

PR-URL: #29382
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
@danbev

This comment has been minimized.

Copy link
Member

commented Sep 3, 2019

Landed in d62d2b4.

@danbev danbev closed this Sep 3, 2019

@cjihrig cjihrig deleted the cjihrig:eslint branch Sep 3, 2019

BridgeAR added a commit that referenced this pull request Sep 3, 2019
tools: update ESLint to 6.3.0
Update ESLint to 6.3.0

PR-URL: #29382
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
@BridgeAR BridgeAR referenced this pull request Sep 3, 2019
BridgeAR added a commit that referenced this pull request Sep 4, 2019
tools: update ESLint to 6.3.0
Update ESLint to 6.3.0

PR-URL: #29382
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
tools: update ESLint to 6.3.0
Update ESLint to 6.3.0

PR-URL: nodejs#29382
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
tools: update ESLint to 6.3.0
Update ESLint to 6.3.0

PR-URL: nodejs#29382
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.