Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto: add oaepLabel option #29489

Closed
wants to merge 2 commits into from

Conversation

@tniessen
Copy link
Member

commented Sep 8, 2019

The label acts as the "L" input to the RSA-OAEP algorithm.

cc @nodejs/crypto @nodejs/security

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
crypto: add oaepLabel option
The label acts as the "L" input to the RSA-OAEP algorithm.
@devnexen
Copy link
Contributor

left a comment

LGTM

src/node_crypto.cc Outdated Show resolved Hide resolved

@tniessen tniessen force-pushed the tniessen:crypto-add-oaep-label branch from 7f37685 to 9410f35 Sep 8, 2019

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment has been minimized.

Copy link

commented Sep 9, 2019

tniessen added a commit that referenced this pull request Sep 13, 2019
crypto: add oaepLabel option
The label acts as the "L" input to the RSA-OAEP algorithm.

PR-URL: #29489
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
tniessen added a commit that referenced this pull request Sep 13, 2019
crypto: fix OpenSSL return code handling
PR-URL: #29489
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@tniessen

This comment has been minimized.

Copy link
Member Author

commented Sep 13, 2019

Landed in dff22dd...3675f40.

@tniessen tniessen closed this Sep 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.