Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf_hooks: add property flags to GCPerformanceEntry #29547

Closed
wants to merge 6 commits into from

Conversation

@fanatid
Copy link
Contributor

fanatid commented Sep 13, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

perf_hooks have kind for GC, but do not have flags

doc/api/perf_hooks.md Outdated Show resolved Hide resolved
@nodejs-github-bot

This comment has been minimized.

doc/api/perf_hooks.md Outdated Show resolved Hide resolved
@Trott Trott removed the author ready label Dec 6, 2019
@nodejs-github-bot

This comment has been minimized.

@Trott

This comment has been minimized.

Copy link
Member

Trott commented Dec 6, 2019

This could use more reviews. /cc @nodejs/performance

@addaleax

This comment has been minimized.

Copy link
Member

addaleax commented Dec 6, 2019

This LGTM code-wise, but it doesn’t really seem to document what these flags indicate (although I guess the same is true for .kind…)


When `performanceEntry.entryType` is equal to `'gc'`, the `performance.flags`
property contain additional information about garbage collection operation.
The value may be one of:

This comment has been minimized.

Copy link
@joyeecheung

joyeecheung Dec 8, 2019

Member

If we are exposing this we at least need a note similar to the one in https://nodejs.org/api/v8.html#v8_v8_getheapspacestatistics

Neither the ordering of heap spaces, nor the availability of a heap space can be guaranteed as the statistics are provided via the V8 GetHeapSpaceStatistics function and may change from one V8 version to the next.

As compared to the GC kind the flags here seem to be even less stable.

This also lacks explanation and they are less self-explanatory compared to the gc kinds. I guess we could link to the v8 docs of GCCallbackFlags at least for reference.

This comment has been minimized.

Copy link
@fanatid

fanatid Dec 8, 2019

Author Contributor

This flags provided via V8 GCCallbackFlags enum and may change from one V8 version to next.

Looks good for adding after constants list?

@BridgeAR

This comment has been minimized.

Copy link
Member

BridgeAR commented Jan 12, 2020

This needs a rebase.

fanatid added 4 commits Sep 13, 2019
@fanatid fanatid force-pushed the fanatid:perf_hooks-add-flags-for-gc branch to 36b01b7 Jan 12, 2020
@fanatid

This comment has been minimized.

Copy link
Contributor Author

fanatid commented Jan 12, 2020

Rebased.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

doc/api/perf_hooks.md Outdated Show resolved Hide resolved
@nodejs-github-bot

This comment has been minimized.

@jasnell

This comment has been minimized.

Copy link
Member

jasnell commented Feb 3, 2020

Failure in CI does not appear relevant but kicked off a new CI just in case

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

addaleax added a commit that referenced this pull request Feb 4, 2020
PR-URL: #29547
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@addaleax

This comment has been minimized.

Copy link
Member

addaleax commented Feb 4, 2020

Landed in 018c3e8

@addaleax addaleax closed this Feb 4, 2020
@fanatid fanatid deleted the fanatid:perf_hooks-add-flags-for-gc branch Feb 4, 2020
codebytere added a commit that referenced this pull request Feb 17, 2020
PR-URL: #29547
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@codebytere codebytere mentioned this pull request Feb 17, 2020
codebytere added a commit that referenced this pull request Feb 18, 2020
Notable changes:

* async_hooks
  * add executionAsyncResource (Matteo Collina) #30959
* crypto
  * add crypto.diffieHellman (Tobias Nießen) #31178
  * add DH support to generateKeyPair (Tobias Nießen) #31178
  * simplify DH groups (Tobias Nießen) #31178
  * add key type 'dh' (Tobias Nießen) #31178
* test
  * skip keygen tests on arm systems (Tobias Nießen) #31178
* perf_hooks
  * add property flags to GCPerformanceEntry (Kirill Fomichev) #29547
* process
  * report ArrayBuffer memory in `memoryUsage()` (Anna Henningsen) #31550
* readline
  * make tab size configurable (Ruben Bridgewater) #31318
* report
  * add support for Workers (Anna Henningsen) #31386
* worker
  * add ability to take heap snapshot from parent thread (Anna Henningsen) #31569
* added new collaborators
  * add ronag to collaborators (Robert Nagy) #31498

PR-URL: #31837
codebytere added a commit that referenced this pull request Feb 18, 2020
Notable changes:

* async_hooks
  * add executionAsyncResource (Matteo Collina) #30959
* crypto
  * add crypto.diffieHellman (Tobias Nießen) #31178
  * add DH support to generateKeyPair (Tobias Nießen) #31178
  * simplify DH groups (Tobias Nießen) #31178
  * add key type 'dh' (Tobias Nießen) #31178
* test
  * skip keygen tests on arm systems (Tobias Nießen) #31178
* perf_hooks
  * add property flags to GCPerformanceEntry (Kirill Fomichev) #29547
* process
  * report ArrayBuffer memory in `memoryUsage()` (Anna Henningsen) #31550
* readline
  * make tab size configurable (Ruben Bridgewater) #31318
* report
  * add support for Workers (Anna Henningsen) #31386
* worker
  * add ability to take heap snapshot from parent thread (Anna Henningsen) #31569
* added new collaborators
  * add ronag to collaborators (Robert Nagy) #31498

PR-URL: #31837
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

9 participants
You can’t perform that action at this time.