Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

domain: do not import util for a simple type check #29825

Closed
wants to merge 2 commits into from

Conversation

@BridgeAR
Copy link
Member

BridgeAR commented Oct 3, 2019

This removes require('util') from the domain module. There was
only a single simple type check used from the util module which
is now inlined instead.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
This removes `require('util')` from the `domain` module. There was
only a single simple type check used from the `util` module which
is now inlined instead.
lib/domain.js Outdated Show resolved Hide resolved
@ZYSzys
ZYSzys approved these changes Oct 3, 2019
@ZYSzys ZYSzys mentioned this pull request Oct 3, 2019
2 of 2 tasks complete
@nodejs-github-bot

This comment has been minimized.

Copy link
Member

Trott left a comment

Needs parentheses (or other change) to pass linter. Otherwise, no objections and this "request changes" can be dismissed.

@Trott Trott dismissed their stale review Oct 13, 2019

parentheses added

@Trott Trott added the author ready label Oct 13, 2019
@nodejs-github-bot

This comment has been minimized.

@Trott

This comment has been minimized.

Copy link
Member

Trott commented Oct 13, 2019

Landed in fce1a51

@Trott Trott closed this Oct 13, 2019
Trott added a commit that referenced this pull request Oct 13, 2019
This removes `require('util')` from the `domain` module. There was
only a single simple type check used from the `util` module which
is now inlined instead.

PR-URL: #29825
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
targos added a commit that referenced this pull request Nov 8, 2019
This removes `require('util')` from the `domain` module. There was
only a single simple type check used from the `util` module which
is now inlined instead.

PR-URL: #29825
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
targos added a commit that referenced this pull request Nov 10, 2019
This removes `require('util')` from the `domain` module. There was
only a single simple type check used from the `util` module which
is now inlined instead.

PR-URL: #29825
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.