Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix tls version values #29839

Closed
wants to merge 2 commits into from

Conversation

@tniessen
Copy link
Member

commented Oct 4, 2019

Some of these values are formatted as strings, fix the formatting of the newer values.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
@Trott
Trott approved these changes Oct 4, 2019
@richardlau

This comment has been minimized.

Copy link
Member

commented Oct 4, 2019

Could you also fix up the similar values in tls.DEFAULT_MAX_VERSION?

@nodejs-github-bot

This comment has been minimized.

Copy link

commented Oct 4, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/25839/

(I kicked off CLI because I'm curious if the main branch is currently flapping for some builds; seems like I'd bumped in to a blip).

@cjihrig
cjihrig approved these changes Oct 4, 2019
@arzzen
arzzen approved these changes Oct 4, 2019
@lpinca
lpinca approved these changes Oct 4, 2019
@trivikr
trivikr approved these changes Oct 4, 2019
@danbev danbev added the author ready label Oct 8, 2019
Copy link
Member

left a comment

Good catch

tniessen added a commit that referenced this pull request Oct 10, 2019
PR-URL: #29839
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@tniessen

This comment has been minimized.

Copy link
Member Author

commented Oct 10, 2019

Landed in 36e83ef, thanks for reviewing!

@tniessen tniessen closed this Oct 10, 2019
targos added a commit that referenced this pull request Oct 14, 2019
PR-URL: #29839
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.