Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmark: add benchmark for vm.createContext #29845

Closed

Conversation

@joyeecheung
Copy link
Member

joyeecheung commented Oct 4, 2019

Refs: #29842

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
@nodejs-github-bot

This comment has been minimized.

@Trott
Trott approved these changes Oct 5, 2019
Copy link
Member

Trott left a comment

FWIW, I confirmed that test/benchmark/test-benchmark-vm.js still passes with this change.

@Trott Trott added the author ready label Oct 5, 2019
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@joyeecheung

This comment has been minimized.

Copy link
Member Author

joyeecheung commented Oct 10, 2019

Landed in 1294c7e

joyeecheung added a commit that referenced this pull request Oct 10, 2019
PR-URL: #29845
Refs: #29842
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos added a commit that referenced this pull request Nov 8, 2019
PR-URL: #29845
Refs: #29842
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.