Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
crypto: remove guard against fixed OpenSSL bug #29854
I expect that to be problematic, yes. I would leave it alone for now.
You could wrap it in a guard if you want to ensure it's not forgotten when we upgrade to 1.2.0:
#if OPENSSL_VERSION_NUMBER >= 0x10200000L #error "Remove this code." #else // ... #endif
So are our docker containers for the sharedlibs builds: https://github.com/nodejs/build/blob/dc94f7e911ea6d2ea90a28a9cf2966a06f2f12f2/ansible/roles/docker/templates/ubuntu1604_sharedlibs.Dockerfile.j2#L57-L65