Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: remove unused using declarations in worker.cc #29883

Closed
wants to merge 1 commit into from

Conversation

@danbev
Copy link
Member

danbev commented Oct 8, 2019

This commit removes unused using declarations in
src/node_worker.cc.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
This commit removes unused using declarations in
src/node_worker.cc.
@nodejs-github-bot

This comment has been minimized.

@cjihrig
cjihrig approved these changes Oct 8, 2019
@ZYSzys
ZYSzys approved these changes Oct 8, 2019
@lpinca
lpinca approved these changes Oct 8, 2019
@Trott

This comment has been minimized.

Copy link
Member

Trott commented Oct 10, 2019

Landed in 179f423

@Trott Trott closed this Oct 10, 2019
Trott added a commit to Trott/io.js that referenced this pull request Oct 10, 2019
This commit removes unused using declarations in
src/node_worker.cc.

PR-URL: nodejs#29883
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@danbev danbev deleted the danbev:worker-unused-using branch Oct 11, 2019
targos added a commit that referenced this pull request Nov 8, 2019
This commit removes unused using declarations in
src/node_worker.cc.

PR-URL: #29883
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.