Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: treat ENOTCONN at shutdown as success #29912

Closed
wants to merge 1 commit into from

Conversation

@addaleax
Copy link
Member

addaleax commented Oct 10, 2019

While it is not entirely clear why this condition is being
triggered, it does resolve a reported bug.

Fixes: #26315

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
While it is not entirely clear why this condition is being
triggered, it does resolve a reported bug.

Fixes: #26315
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@addaleax

This comment has been minimized.

Copy link
Member Author

addaleax commented Oct 11, 2019

@nodejs/collaborators This could use a review or two.

Copy link
Member

jasnell left a comment

LGTM, but is there anything reasonable that can be included in the docs about this?

@addaleax

This comment has been minimized.

Copy link
Member Author

addaleax commented Oct 11, 2019

@jasnell I wouldn’t know how or what to document. This kind of just makes behaviour be what it should be in the first place.

@jasnell

This comment has been minimized.

Copy link
Member

jasnell commented Oct 11, 2019

Yeah, that's kind of what I expected.

@lpinca
lpinca approved these changes Oct 11, 2019
@addaleax addaleax added author ready and removed review wanted labels Oct 11, 2019
@addaleax

This comment has been minimized.

Copy link
Member Author

addaleax commented Oct 12, 2019

Landed in 1447a79

@addaleax addaleax closed this Oct 12, 2019
addaleax added a commit that referenced this pull request Oct 12, 2019
While it is not entirely clear why this condition is being
triggered, it does resolve a reported bug.

Fixes: #26315

PR-URL: #29912
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@addaleax addaleax deleted the addaleax:shutdown-enotconn branch Oct 12, 2019
addaleax added a commit to addaleax/node that referenced this pull request Oct 14, 2019
While it is not entirely clear why this condition is being
triggered, it does resolve a reported bug.

Fixes: nodejs#26315

PR-URL: nodejs#29912
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BethGriggs added a commit that referenced this pull request Oct 16, 2019
While it is not entirely clear why this condition is being
triggered, it does resolve a reported bug.

Fixes: #26315

PR-URL: #29912
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BethGriggs added a commit that referenced this pull request Oct 16, 2019
While it is not entirely clear why this condition is being
triggered, it does resolve a reported bug.

Fixes: #26315

Backport-PR-URL: #29968
PR-URL: #29912
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
addaleax added a commit that referenced this pull request Oct 25, 2019
While it is not entirely clear why this condition is being
triggered, it does resolve a reported bug.

Fixes: #26315

PR-URL: #29912
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.