Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: remove unused Markdown reference links #29961

Closed
wants to merge 2 commits into from

Conversation

@nschonni
Copy link
Member

nschonni commented Oct 14, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
@nschonni

This comment has been minimized.

Copy link
Member Author

nschonni commented Oct 14, 2019

Could split these 2 commits out to separate PRs, but was just probing to see what inline remark-lint disabled rules could be re-enabled using the latest master of the remark-node-preset

@@ -4631,8 +4631,6 @@ that points to its own memory allocated by a native module). Registering
externally allocated memory will trigger global garbage collections more
often than it would otherwise.

<!-- it's very convenient to have all the anchors indexed -->

This comment has been minimized.

Copy link
@nschonni

nschonni Oct 14, 2019

Author Member

This is the only document that has it this way, and has been disabled for 2 years

@Trott
Trott approved these changes Oct 16, 2019
@Trott

This comment has been minimized.

@Trott Trott added the author ready label Oct 16, 2019
@Trott

This comment has been minimized.

Copy link
Member

Trott commented Oct 16, 2019

Landed in 405a280...46648eb

@Trott Trott closed this Oct 16, 2019
Trott added a commit to Trott/io.js that referenced this pull request Oct 16, 2019
PR-URL: nodejs#29961
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Trott added a commit that referenced this pull request Oct 16, 2019
PR-URL: #29961
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@nschonni nschonni deleted the nschonni:remark-lint-inline-cleanup branch Oct 16, 2019
MylesBorins added a commit that referenced this pull request Oct 23, 2019
PR-URL: #29961
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
MylesBorins added a commit that referenced this pull request Oct 23, 2019
PR-URL: #29961
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@MylesBorins MylesBorins mentioned this pull request Oct 23, 2019
targos added a commit that referenced this pull request Nov 8, 2019
PR-URL: #29961
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
targos added a commit that referenced this pull request Nov 8, 2019
PR-URL: #29961
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
targos added a commit that referenced this pull request Nov 10, 2019
PR-URL: #29961
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
targos added a commit that referenced this pull request Nov 10, 2019
PR-URL: #29961
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.