Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix version checks in configure.py #29965

Closed
wants to merge 1 commit into from

Conversation

@targos
Copy link
Member

targos commented Oct 14, 2019

Fixes: #29927
Refs: #29931

Fixes: #29927
Refs: #29931
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@lpinca
lpinca approved these changes Oct 14, 2019
Copy link
Member

bnoordhuis left a comment

The long lines are kind of regrettable but I'll get over it.

targos added a commit that referenced this pull request Oct 18, 2019
Fixes: #29927
Refs: #29931

PR-URL: #29965
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@targos

This comment has been minimized.

Copy link
Member Author

targos commented Oct 18, 2019

Landed in d769ebc

@targos targos closed this Oct 18, 2019
@targos targos deleted the targos:py-strictversion branch Oct 18, 2019
MylesBorins added a commit that referenced this pull request Oct 23, 2019
Fixes: #29927
Refs: #29931

PR-URL: #29965
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
MylesBorins added a commit that referenced this pull request Oct 23, 2019
Fixes: #29927
Refs: #29931

PR-URL: #29965
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@MylesBorins MylesBorins mentioned this pull request Oct 23, 2019
targos added a commit that referenced this pull request Nov 8, 2019
Fixes: #29927
Refs: #29931

PR-URL: #29965
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
targos added a commit that referenced this pull request Nov 10, 2019
Fixes: #29927
Refs: #29931

PR-URL: #29965
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.