Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix fs benchmark test #29967

Closed
wants to merge 0 commits into from
Closed

test: fix fs benchmark test #29967

wants to merge 0 commits into from

Conversation

@Trott
Copy link
Member

Trott commented Oct 14, 2019

Add missing option "mode". Alphabetize options for easier maintenance.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@Trott

This comment has been minimized.

Copy link
Member Author

Trott commented Oct 14, 2019

I'd like to fast-track this to fix nightly CI.

Example: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/9482/testReport/junit/(root)/test/benchmark_test_benchmark_fs/

Please 👍 here to approve if you're a collaborator. Thanks!

@Trott Trott added the fast-track label Oct 14, 2019
@nodejs-github-bot

This comment was marked as outdated.

@Trott

This comment has been minimized.

Copy link
Member Author

Trott commented Oct 14, 2019

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3991/ (benchmark tests are not run in regular CI)

Trott added a commit to Trott/io.js that referenced this pull request Oct 14, 2019
Add missing option "mode". Alphabetize options for easier maintenance.

PR-URL: nodejs#29967
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
@Trott

This comment has been minimized.

Copy link
Member Author

Trott commented Oct 14, 2019

Landed in 7991b57

@Trott Trott closed this Oct 14, 2019
@Trott Trott reopened this Oct 14, 2019
@Trott Trott closed this Oct 14, 2019
@Trott Trott force-pushed the Trott:fix-benchmark-tests branch from 158968b to 7991b57 Oct 14, 2019
targos added a commit that referenced this pull request Nov 8, 2019
Add missing option "mode". Alphabetize options for easier maintenance.

PR-URL: #29967
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
targos added a commit that referenced this pull request Nov 10, 2019
Add missing option "mode". Alphabetize options for easier maintenance.

PR-URL: #29967
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.