From 0254759df7a68f4fc9a3ab0b0d5c24a63bd0e097 Mon Sep 17 00:00:00 2001 From: Daniel Bevenius Date: Thu, 17 Oct 2019 09:23:32 +0200 Subject: [PATCH 1/2] src: remove unnecessary std::endl usage This commit removes a few std::endl that could be replaced by '\n' as it does not look like the buffer needs to be flushed in these places. This is only done in error handling, and once when the report has been generated, so this is very minor but I thought I'd bring it up in case it was overlooked. --- src/node_report.cc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/node_report.cc b/src/node_report.cc index 088c63b9e8402d..01cafd9206d78b 100644 --- a/src/node_report.cc +++ b/src/node_report.cc @@ -111,7 +111,7 @@ std::string TriggerNodeReport(Isolate* isolate, } // Check for errors on the file open if (!outfile.is_open()) { - std::cerr << std::endl + std::cerr << '\n' << "Failed to open Node.js report file: " << filename; if (env != nullptr && options->report_directory.length() > 0) @@ -121,7 +121,7 @@ std::string TriggerNodeReport(Isolate* isolate, return ""; } outstream = &outfile; - std::cerr << std::endl << "Writing Node.js report to file: " << filename; + std::cerr << '\n' << "Writing Node.js report to file: " << filename; } WriteNodeReport(isolate, env, message, trigger, filename, *outstream, @@ -132,7 +132,7 @@ std::string TriggerNodeReport(Isolate* isolate, outfile.close(); } - std::cerr << std::endl << "Node.js report completed" << std::endl; + std::cerr << '\n' << "Node.js report completed" << std::endl; return filename; } From 2c6b9fa485197c0715584494a47e3de33b6e5873 Mon Sep 17 00:00:00 2001 From: Daniel Bevenius Date: Mon, 21 Oct 2019 06:56:44 +0200 Subject: [PATCH 2/2] squash: "fold" '\n' into strings --- src/node_report.cc | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/node_report.cc b/src/node_report.cc index 01cafd9206d78b..c694eaf435e19a 100644 --- a/src/node_report.cc +++ b/src/node_report.cc @@ -111,8 +111,7 @@ std::string TriggerNodeReport(Isolate* isolate, } // Check for errors on the file open if (!outfile.is_open()) { - std::cerr << '\n' - << "Failed to open Node.js report file: " << filename; + std::cerr << "\nFailed to open Node.js report file: " << filename; if (env != nullptr && options->report_directory.length() > 0) std::cerr << " directory: " << options->report_directory; @@ -121,7 +120,7 @@ std::string TriggerNodeReport(Isolate* isolate, return ""; } outstream = &outfile; - std::cerr << '\n' << "Writing Node.js report to file: " << filename; + std::cerr << "\nWriting Node.js report to file: " << filename; } WriteNodeReport(isolate, env, message, trigger, filename, *outstream, @@ -132,7 +131,7 @@ std::string TriggerNodeReport(Isolate* isolate, outfile.close(); } - std::cerr << '\n' << "Node.js report completed" << std::endl; + std::cerr << "\nNode.js report completed" << std::endl; return filename; }