Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update collaborator email address #30007

Merged
merged 1 commit into from Oct 19, 2019

Conversation

@JungMinu
Copy link
Member

JungMinu commented Oct 17, 2019

update my personal email in README

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
@JungMinu JungMinu self-assigned this Oct 17, 2019
Copy link
Member

richardlau left a comment

If you have any commits with the old email address you can optionally remap them in https://github.com/nodejs/node/blob/master/.mailmap for the purposes of the AUTHORS file.

@Trott
Trott approved these changes Oct 18, 2019
JungMinu added a commit to JungMinu/node that referenced this pull request Oct 18, 2019
update collaborator email address

PR-URL: nodejs#30007
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@JungMinu JungMinu force-pushed the JungMinu:meta branch from cc372ca to 9ae767d Oct 18, 2019
@JungMinu JungMinu changed the title meta: update personal info doc: update collaborator email address Oct 19, 2019
update collaborator email address

PR-URL: #30007
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@JungMinu JungMinu force-pushed the JungMinu:meta branch from 9ae767d to 425357a Oct 19, 2019
@JungMinu JungMinu merged commit 425357a into nodejs:master Oct 19, 2019
1 check failed
1 check failed
Travis CI - Pull Request Build Errored
Details
@JungMinu JungMinu deleted the JungMinu:meta branch Oct 19, 2019
@JungMinu

This comment has been minimized.

Copy link
Member Author

JungMinu commented Oct 19, 2019

Landed in 425357a

MylesBorins added a commit that referenced this pull request Oct 23, 2019
update collaborator email address

PR-URL: #30007
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins added a commit that referenced this pull request Oct 23, 2019
update collaborator email address

PR-URL: #30007
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Oct 23, 2019
targos added a commit that referenced this pull request Nov 8, 2019
update collaborator email address

PR-URL: #30007
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos added a commit that referenced this pull request Nov 10, 2019
update collaborator email address

PR-URL: #30007
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos added a commit that referenced this pull request Nov 11, 2019
update collaborator email address

PR-URL: #30007
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.