Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix test runner for Python 3 on Windows #30023

Closed
wants to merge 1 commit into from

Conversation

@targos
Copy link
Member

targos commented Oct 18, 2019

Explicitly open files with utf8 encoding, otherwise the system could use
another encoding such as latin1 by default.

/cc @nodejs/python

@richardlau richardlau dismissed their stale review Oct 18, 2019

Doesn’t seem to be compatible with Python 2

@cclauss

This comment has been minimized.

Copy link
Contributor

cclauss commented Oct 18, 2019

On legacy Python, this will raise:
TypeError: 'encoding' is an invalid keyword argument for this function

@targos

This comment has been minimized.

Copy link
Member Author

targos commented Oct 18, 2019

How can we make it compatible with legacy Python?

@cclauss

This comment has been minimized.

Copy link
Contributor

cclauss commented Oct 18, 2019

Explicitly open files with utf8 encoding, otherwise the system could use
another encoding such as latin1 by default.
@targos targos force-pushed the targos:py3-win-test branch from 9b27fe6 to a6d74ec Oct 18, 2019
@nodejs-github-bot

This comment has been minimized.

@lpinca
lpinca approved these changes Oct 18, 2019
@targos

This comment has been minimized.

Copy link
Member Author

targos commented Oct 20, 2019

Landed in a4e075f

@targos targos closed this Oct 20, 2019
@targos targos deleted the targos:py3-win-test branch Oct 20, 2019
targos added a commit that referenced this pull request Oct 20, 2019
Explicitly open files with utf8 encoding, otherwise the system could use
another encoding such as latin1 by default.

PR-URL: #30023
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins added a commit that referenced this pull request Oct 23, 2019
Explicitly open files with utf8 encoding, otherwise the system could use
another encoding such as latin1 by default.

PR-URL: #30023
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins added a commit that referenced this pull request Oct 23, 2019
Explicitly open files with utf8 encoding, otherwise the system could use
another encoding such as latin1 by default.

PR-URL: #30023
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Oct 23, 2019
targos added a commit that referenced this pull request Nov 8, 2019
Explicitly open files with utf8 encoding, otherwise the system could use
another encoding such as latin1 by default.

PR-URL: #30023
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos added a commit that referenced this pull request Nov 10, 2019
Explicitly open files with utf8 encoding, otherwise the system could use
another encoding such as latin1 by default.

PR-URL: #30023
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos added a commit that referenced this pull request Nov 11, 2019
Explicitly open files with utf8 encoding, otherwise the system could use
another encoding such as latin1 by default.

PR-URL: #30023
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.