Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: join parts of disrupt section in cli.md #30038

Closed

Conversation

@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented Oct 19, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Also eliminate some redundancy.

It seems this is the history of this small confusion and redundancy:

4b74dae#diff-85b6573bc4afd5e06ed3b9d9b553635d

4fbefc4#diff-85b6573bc4afd5e06ed3b9d9b553635d

@ZYSzys
ZYSzys approved these changes Oct 19, 2019
@Trott
Trott approved these changes Oct 19, 2019
@Trott

This comment has been minimized.

Copy link
Member

Trott commented Oct 19, 2019

Commit message nit: Maybe mention that it's for the CLI docs?

Also eliminate some redundancy.
@vsemozhetbyt vsemozhetbyt force-pushed the vsemozhetbyt:doc-cli-join-section branch from 891148c to 1d8abad Oct 19, 2019
@vsemozhetbyt vsemozhetbyt changed the title doc: join parts of disrupt section doc: join parts of disrupt section in cli.md Oct 19, 2019
@vsemozhetbyt

This comment has been minimized.

Copy link
Contributor Author

vsemozhetbyt commented Oct 19, 2019

Done)

@Trott

This comment has been minimized.

@lpinca
lpinca approved these changes Oct 20, 2019
Trott added a commit that referenced this pull request Oct 22, 2019
Also eliminate some redundancy.

PR-URL: #30038
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Trott

This comment has been minimized.

Copy link
Member

Trott commented Oct 22, 2019

Landed in 0ecd3c6

@Trott Trott closed this Oct 22, 2019
@vsemozhetbyt vsemozhetbyt deleted the vsemozhetbyt:doc-cli-join-section branch Oct 22, 2019
MylesBorins added a commit that referenced this pull request Oct 23, 2019
Also eliminate some redundancy.

PR-URL: #30038
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins added a commit that referenced this pull request Oct 23, 2019
Also eliminate some redundancy.

PR-URL: #30038
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Oct 23, 2019
targos added a commit that referenced this pull request Nov 8, 2019
Also eliminate some redundancy.

PR-URL: #30038
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos added a commit that referenced this pull request Nov 10, 2019
Also eliminate some redundancy.

PR-URL: #30038
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos added a commit that referenced this pull request Nov 11, 2019
Also eliminate some redundancy.

PR-URL: #30038
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
9 participants
You can’t perform that action at this time.