Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: --enable-source-maps and prepareStackTrace are incompatible #30046

Closed
wants to merge 3 commits into from

Conversation

@bcoe
Copy link
Member

bcoe commented Oct 21, 2019

document the fact that --enable-source-maps and prepareStackTrace are
incompatible, see #29994

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
document the fact that --enable-source-maps and prepareStackTrace are
incompatible, see #29994
doc/api/cli.md Outdated Show resolved Hide resolved
doc/api/cli.md Outdated Show resolved Hide resolved
Copy link
Contributor

cjihrig left a comment

LGTM with the suggestions incorporated.

@lpinca
lpinca approved these changes Oct 21, 2019
bcoe added 2 commits Oct 22, 2019
@nodejs-github-bot

This comment has been minimized.

bcoe added a commit that referenced this pull request Oct 23, 2019
document the fact that --enable-source-maps and prepareStackTrace are
incompatible, see #29994

PR-URL: #30046
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@bcoe

This comment has been minimized.

Copy link
Member Author

bcoe commented Oct 23, 2019

Landed in b964e77

@bcoe bcoe closed this Oct 23, 2019
@bcoe bcoe deleted the bcoe:doc-29994 branch Oct 23, 2019
MylesBorins added a commit that referenced this pull request Oct 23, 2019
document the fact that --enable-source-maps and prepareStackTrace are
incompatible, see #29994

PR-URL: #30046
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
MylesBorins added a commit that referenced this pull request Oct 23, 2019
document the fact that --enable-source-maps and prepareStackTrace are
incompatible, see #29994

PR-URL: #30046
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Oct 23, 2019
@addaleax addaleax added the source maps label Nov 2, 2019
targos added a commit that referenced this pull request Nov 8, 2019
document the fact that --enable-source-maps and prepareStackTrace are
incompatible, see #29994

PR-URL: #30046
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
targos added a commit that referenced this pull request Nov 10, 2019
document the fact that --enable-source-maps and prepareStackTrace are
incompatible, see #29994

PR-URL: #30046
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
targos added a commit that referenced this pull request Nov 11, 2019
document the fact that --enable-source-maps and prepareStackTrace are
incompatible, see #29994

PR-URL: #30046
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.