Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto: guard with OPENSSL_NO_GOST #30050

Closed
wants to merge 1 commit into from

Conversation

@codebytere
Copy link
Member

codebytere commented Oct 21, 2019

This PR wraps references to Gost-based NIDs inside GetSharedSigalgs with OPENSSL_NO_GOST. This helps prevent compilation failures in Electron owing to BoringSSL incompatibilities as well as reduces the size of Node's shipped binary by removing some potentially unnecessary code.

cc @tniessen

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
src/node_crypto.cc Outdated Show resolved Hide resolved
@codebytere codebytere force-pushed the codebytere:openssl-no-gost branch from d3a3f77 to d35b39e Oct 21, 2019
@nodejs-github-bot

This comment has been minimized.

@danbev danbev added the author ready label Oct 23, 2019
danbev added a commit that referenced this pull request Oct 24, 2019
PR-URL: #30050
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@danbev

This comment has been minimized.

Copy link
Member

danbev commented Oct 24, 2019

Landed in a228e22.

@danbev danbev closed this Oct 24, 2019
targos added a commit that referenced this pull request Oct 24, 2019
PR-URL: #30050
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@targos targos mentioned this pull request Nov 5, 2019
targos added a commit that referenced this pull request Nov 8, 2019
PR-URL: #30050
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
targos added a commit that referenced this pull request Nov 10, 2019
PR-URL: #30050
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
targos added a commit that referenced this pull request Nov 11, 2019
PR-URL: #30050
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.