Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use -latomic on macOS #30099

Closed
wants to merge 1 commit into from
Closed

Don't use -latomic on macOS #30099

wants to merge 1 commit into from

Conversation

@ryandesign
Copy link
Contributor

ryandesign commented Oct 23, 2019

Fixes build when using open-source clang. (Builds using Apple clang from Xcode
7 and later were already working, due to the fact that node's build system
misidentifies their llvm_version as "0.0" and thus the flag wasn't being added.)

Closes #30093

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Fixes build when using open-source clang. (Builds using Apple clang from Xcode
7 and later were already working, due to the fact that node's build system
misidentifies their llvm_version as "0.0" and thus the flag wasn't being added.)

Closes #30093
Copy link
Member

richardlau left a comment

Looks okay to me but I don't have a mac so can't test this.

cc @nodejs/platform-macos @nodejs/build-files

@nodejs-github-bot

This comment has been minimized.

@marsam marsam mentioned this pull request Nov 19, 2019
1 of 4 tasks complete
@BridgeAR

This comment has been minimized.

Copy link
Member

BridgeAR commented Dec 25, 2019

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment has been minimized.

Copy link

nodejs-github-bot commented Dec 26, 2019

@BridgeAR BridgeAR requested a review from devsnek Jan 1, 2020
@devsnek devsnek removed their request for review Jan 1, 2020
@devsnek

This comment has been minimized.

Copy link
Member

devsnek commented Jan 1, 2020

I don't have a mac anymore, so I can't test or verify this.

@ljharb

This comment has been minimized.

Copy link
Member

ljharb commented Jan 1, 2020

./configure && make passed on my Mac with an unset CXX, and CXX=g++. I'll leave it to someone else to test homebrew's clang++.

Copy link
Member

BridgeAR left a comment

RSLGTM

BridgeAR added a commit that referenced this pull request Jan 2, 2020
Fixes build when using open-source clang.

Builds using Apple clang from Xcode v7 and later were already working,
due to the fact that node's build system misidentifies their
llvm_version as "0.0" and thus the flag wasn't being added.

PR-URL: #30099
Fixes: #30093
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR

This comment has been minimized.

Copy link
Member

BridgeAR commented Jan 2, 2020

Landed in 4bd0d8c 🎉

@BridgeAR BridgeAR closed this Jan 2, 2020
@BridgeAR

This comment has been minimized.

Copy link
Member

BridgeAR commented Jan 2, 2020

@ryandesign congratulations on your first commit to Node.js! 🎉

@ryandesign ryandesign deleted the ryandesign:patch-1 branch Jan 3, 2020
BridgeAR added a commit that referenced this pull request Jan 3, 2020
Fixes build when using open-source clang.

Builds using Apple clang from Xcode v7 and later were already working,
due to the fact that node's build system misidentifies their
llvm_version as "0.0" and thus the flag wasn't being added.

PR-URL: #30099
Fixes: #30093
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR BridgeAR mentioned this pull request Jan 7, 2020
targos added a commit that referenced this pull request Jan 14, 2020
Fixes build when using open-source clang.

Builds using Apple clang from Xcode v7 and later were already working,
due to the fact that node's build system misidentifies their
llvm_version as "0.0" and thus the flag wasn't being added.

PR-URL: #30099
Fixes: #30093
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.