Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: update ESLint to 6.6.0 #30123

Merged
merged 1 commit into from Oct 28, 2019
Merged

tools: update ESLint to 6.6.0 #30123

merged 1 commit into from Oct 28, 2019

Conversation

@cjihrig
Copy link
Contributor

cjihrig commented Oct 25, 2019

Update ESLint to 6.6.0

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@lpinca
lpinca approved these changes Oct 25, 2019
@lpinca

This comment has been minimized.

Copy link
Member

lpinca commented Oct 25, 2019

RSLGTM.

@Trott
Trott approved these changes Oct 25, 2019
Copy link
Member

Trott left a comment

Rubber-stamp LGTM

@ZYSzys
ZYSzys approved these changes Oct 26, 2019
Copy link
Member

ZYSzys left a comment

RSLGTM

@ZYSzys ZYSzys added the author ready label Oct 26, 2019
Copy link
Member

trivikr left a comment

RSLGTM

@Trott

This comment has been minimized.

Copy link
Member

Trott commented Oct 26, 2019

Update ESLint to 6.6.0

PR-URL: #30123
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@cjihrig cjihrig force-pushed the cjihrig:eslint branch from cf3204d to 511f67b Oct 28, 2019
@cjihrig cjihrig merged commit 511f67b into nodejs:master Oct 28, 2019
1 check failed
1 check failed
Travis CI - Pull Request Build Errored
Details
@cjihrig cjihrig deleted the cjihrig:eslint branch Oct 28, 2019
targos added a commit that referenced this pull request Nov 5, 2019
Update ESLint to 6.6.0

PR-URL: #30123
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@targos targos mentioned this pull request Nov 5, 2019
targos added a commit that referenced this pull request Nov 8, 2019
Update ESLint to 6.6.0

PR-URL: #30123
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos added a commit that referenced this pull request Nov 10, 2019
Update ESLint to 6.6.0

PR-URL: #30123
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos added a commit that referenced this pull request Nov 10, 2019
Update ESLint to 6.6.0

PR-URL: #30123
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos added a commit that referenced this pull request Nov 11, 2019
Update ESLint to 6.6.0

PR-URL: #30123
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.