Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc,meta: prefer aliases and stubs over Runtime Deprecations #30153

Merged
merged 1 commit into from Oct 30, 2019
+3 −0

Conversation

@Trott
Copy link
Member

Trott commented Oct 28, 2019 •
edited

Avoid Runtime Deprecations when an alias or a stub/no-op will suffice.
An alias or stub will have lower maintenance costs for end users and Node.js core.

Refs: #29989 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
@Trott Trott force-pushed the Trott:no-op-deps branch from 0e6b37e to 0905254 Oct 28, 2019
@addaleax
addaleax approved these changes Oct 28, 2019
View changes
@Trott Trott mentioned this pull request Oct 28, 2019
Closed
@targos
targos approved these changes Oct 28, 2019
View changes
@lholmquist
lholmquist approved these changes Oct 28, 2019
View changes
@cjihrig
cjihrig approved these changes Oct 28, 2019
View changes
@fhinkel
fhinkel approved these changes Oct 28, 2019
View changes
Copy link
Member

fhinkel left a comment

👍
@trivikr
trivikr approved these changes Oct 28, 2019
View changes
@lpinca
lpinca approved these changes Oct 28, 2019
View changes
@gireeshpunathil
gireeshpunathil approved these changes Oct 29, 2019
View changes
@mhdawson
mhdawson approved these changes Oct 29, 2019
View changes
Copy link
Member

mhdawson left a comment

LGTM
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member Author

Trott commented Oct 30, 2019

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4018/
@Trott
doc,meta: prefer aliases and stubs over Runtime Deprecations
Loading status checks…
8fa4abd 
Avoid Runtime Deprecations when an alias or a stub/no-op will suffice.
An alias or stub will have lower maintenance costs for end users.

Refs: #29989 (comment)

PR-URL: #30153
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@Trott Trott force-pushed the Trott:no-op-deps branch from bc1e585 to 8fa4abd Oct 30, 2019
@Trott Trott merged commit 8fa4abd into nodejs:master Oct 30, 2019
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member Author

Trott commented Oct 30, 2019

Landed in 8fa4abd
targos added a commit that referenced this pull request Nov 5, 2019
@Trott @targos
doc,meta: prefer aliases and stubs over Runtime Deprecations
Verified
This commit was signed with a verified signature.
targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
978946e 
Avoid Runtime Deprecations when an alias or a stub/no-op will suffice.
An alias or stub will have lower maintenance costs for end users.

Refs: #29989 (comment)

PR-URL: #30153
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@targos targos mentioned this pull request Nov 5, 2019
Merged
targos added a commit that referenced this pull request Nov 8, 2019
@Trott @targos
doc,meta: prefer aliases and stubs over Runtime Deprecations
Verified
This commit was signed with a verified signature.
targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
63326fc 
Avoid Runtime Deprecations when an alias or a stub/no-op will suffice.
An alias or stub will have lower maintenance costs for end users.

Refs: #29989 (comment)

PR-URL: #30153
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
targos added a commit that referenced this pull request Nov 10, 2019
@Trott @targos
doc,meta: prefer aliases and stubs over Runtime Deprecations
Verified
This commit was signed with a verified signature.
targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
976d46a 
Avoid Runtime Deprecations when an alias or a stub/no-op will suffice.
An alias or stub will have lower maintenance costs for end users.

Refs: #29989 (comment)

PR-URL: #30153
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
targos added a commit that referenced this pull request Nov 10, 2019
@Trott @targos
doc,meta: prefer aliases and stubs over Runtime Deprecations
Verified
This commit was signed with a verified signature.
targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
9e66bfc 
Avoid Runtime Deprecations when an alias or a stub/no-op will suffice.
An alias or stub will have lower maintenance costs for end users.

Refs: #29989 (comment)

PR-URL: #30153
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@targos targos mentioned this pull request Nov 10, 2019
Merged
targos added a commit that referenced this pull request Nov 11, 2019
@Trott @targos
doc,meta: prefer aliases and stubs over Runtime Deprecations
Verified
This commit was signed with a verified signature.
targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
66c6818 
Avoid Runtime Deprecations when an alias or a stub/no-op will suffice.
An alias or stub will have lower maintenance costs for end users.

Refs: #29989 (comment)

PR-URL: #30153
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fhinkel fhinkel

@addaleax addaleax

@lholmquist lholmquist

@lpinca lpinca

@targos targos

@cjihrig cjihrig

@gireeshpunathil gireeshpunathil

@mhdawson mhdawson

@trivikr trivikr

Assignees
No one assigned
Labels
doc
Projects
None yet
Milestone
No milestone
You can’t perform that action at this time.