Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: improve doc Http2Session:Timeout #30161

Closed
wants to merge 1 commit into from

Conversation

@dev-313
Copy link
Contributor

dev-313 commented Oct 29, 2019

Add line in doc/http2.md for 'timeout' event which tell readers
that 'timeout' event doesn't expect any arguments.

Fixes: nodejs/help#877

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Add line in doc/http2.md for 'timeout' event which tell readers
that 'timeout' event doesn't except any arguments.

Fixes: nodejs/help#877
@lpinca
lpinca approved these changes Oct 29, 2019
@gireeshpunathil

This comment has been minimized.

gireeshpunathil added a commit that referenced this pull request Oct 31, 2019
Add line in doc/http2.md for 'timeout' event which tell readers
that 'timeout' event doesn't except any arguments.

Refs: nodejs/help#877
PR-URL: #30161
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@gireeshpunathil

This comment has been minimized.

Copy link
Member

gireeshpunathil commented Oct 31, 2019

landed as 99247e7

targos added a commit that referenced this pull request Nov 5, 2019
Add line in doc/http2.md for 'timeout' event which tell readers
that 'timeout' event doesn't except any arguments.

Refs: nodejs/help#877
PR-URL: #30161
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@targos targos mentioned this pull request Nov 5, 2019
targos added a commit that referenced this pull request Nov 8, 2019
Add line in doc/http2.md for 'timeout' event which tell readers
that 'timeout' event doesn't except any arguments.

Refs: nodejs/help#877
PR-URL: #30161
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos added a commit that referenced this pull request Nov 10, 2019
Add line in doc/http2.md for 'timeout' event which tell readers
that 'timeout' event doesn't except any arguments.

Refs: nodejs/help#877
PR-URL: #30161
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos added a commit that referenced this pull request Nov 10, 2019
Add line in doc/http2.md for 'timeout' event which tell readers
that 'timeout' event doesn't except any arguments.

Refs: nodejs/help#877
PR-URL: #30161
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos added a commit that referenced this pull request Nov 11, 2019
Add line in doc/http2.md for 'timeout' event which tell readers
that 'timeout' event doesn't except any arguments.

Refs: nodejs/help#877
PR-URL: #30161
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.