Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: improve doc Http2Stream:Aborted #30179

Closed
wants to merge 1 commit into from

Conversation

@dev-313
Copy link
Contributor

dev-313 commented Oct 30, 2019

Line added in the description of http2 aborted event
that it's listener does not expect any arguments.

Fixes: nodejs/help#877

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
@dev-313 dev-313 changed the title docs: improve doc Http2Stream:Aborted doc: improve doc Http2Stream:Aborted Oct 30, 2019
Line added in the description of http2 aborted event
that it's listener does not expect any arguments.

Fixes: nodejs/help#877
@dev-313 dev-313 force-pushed the dev-313:docs/http2-event-aborted branch from 7b231ee to d27978b Oct 30, 2019
@gireeshpunathil

This comment has been minimized.

Copy link
Member

gireeshpunathil commented Oct 30, 2019

@dev-313 - if you are planning to attack all of those pending http2 event arguments mentioned in the referenced issue, it may be a good idea to combine the rest into one single PR - easy to review, easy to manage.

@dev-313

This comment has been minimized.

Copy link
Contributor Author

dev-313 commented Oct 30, 2019

Okay @gireeshpunathil . Thanks

@trivikr

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@gireeshpunathil

This comment has been minimized.

Copy link
Member

gireeshpunathil commented Oct 31, 2019

@nodejs/build - can you please review https://ci.nodejs.org/job/node-linter/3957/console and advise what is going on? does not look like a normal build failure to me.

@richardlau

This comment has been minimized.

Copy link
Member

richardlau commented Oct 31, 2019

@nodejs/build - can you please review https://ci.nodejs.org/job/node-linter/3957/console and advise what is going on? does not look like a normal build failure to me.

@rvagg I think this is related to nodejs/build#2012 (comment).

The Pre-flight stage of https://ci.nodejs.org/job/node-linter/ calls https://raw.githubusercontent.com/nodejs/build/master/jenkins/scripts/node-test-commit-pre.sh

sh "curl -L -s https://raw.githubusercontent.com/nodejs/build/master/jenkins/scripts/node-test-commit-pre.sh -s | bash -xe"

which calls https://raw.githubusercontent.com/nodejs/build/master/jenkins/scripts/node-test-commit-diagnostics.sh
which tries to write to DIAGFILE=${HOME}/jenkins_diagnostics.txt and fails:

01:40:36  + curl https://raw.githubusercontent.com/nodejs/build/master/jenkins/scripts/node-test-commit-diagnostics.sh
01:40:36  + bash -ex -s before
01:40:36    % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
01:40:36                                   Dload  Upload   Total   Spent    Left  Speed
01:40:37  
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100   985  100   985    0     0   3315      0 --:--:-- --:--:-- --:--:--  3327
01:40:37  + set +x
01:40:37  bash: line 9: /jenkins_diagnostics.txt: Permission denied

suggesting ${HOME} is empty?

@rvagg

This comment has been minimized.

Copy link
Member

rvagg commented Oct 31, 2019

Yes, and I can't work out why $HOME is missing now that we've switched from FreeBSD to Linux for this. There's no special environment variables on the host machine.

@rvagg

This comment has been minimized.

Copy link
Member

rvagg commented Oct 31, 2019

I've restored the old FreeBSD servers while we figure this one out. These pipeline builds are the worst for debugging, I've got no idea where HOME has gone to, it's not showing up on an env from the script but there's nothing particularly special about the FreeBSD env compared to the Ubuntu one for that.

@rvagg

This comment has been minimized.

Copy link
Member

rvagg commented Oct 31, 2019

Got this sorted out, it was a configuration weirdness specific to the machine that has the most likelihood of being chosen for this task nodejs/build#2021, it's now back off FreeBSD.

gireeshpunathil added a commit that referenced this pull request Nov 3, 2019
Line added in the description of http2 aborted event
that it's listener does not expect any arguments.

Refs: nodejs/help#877
PR-URL: #30179
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@gireeshpunathil

This comment has been minimized.

Copy link
Member

gireeshpunathil commented Nov 3, 2019

landed as 8b53d0b

targos added a commit that referenced this pull request Nov 5, 2019
Line added in the description of http2 aborted event
that it's listener does not expect any arguments.

Refs: nodejs/help#877
PR-URL: #30179
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@targos targos mentioned this pull request Nov 5, 2019
targos added a commit that referenced this pull request Nov 8, 2019
Line added in the description of http2 aborted event
that it's listener does not expect any arguments.

Refs: nodejs/help#877
PR-URL: #30179
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos added a commit that referenced this pull request Nov 10, 2019
Line added in the description of http2 aborted event
that it's listener does not expect any arguments.

Refs: nodejs/help#877
PR-URL: #30179
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos added a commit that referenced this pull request Nov 10, 2019
Line added in the description of http2 aborted event
that it's listener does not expect any arguments.

Refs: nodejs/help#877
PR-URL: #30179
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos added a commit that referenced this pull request Nov 11, 2019
Line added in the description of http2 aborted event
that it's listener does not expect any arguments.

Refs: nodejs/help#877
PR-URL: #30179
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.