Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: make doctool work if no internet available #30214

Merged
merged 1 commit into from Nov 6, 2019

Conversation

@richardlau
Copy link
Member

richardlau commented Nov 2, 2019

Allow doctool to fallback to use local files if not building a release
build.

Fixes: #29918

cc @joyeecheung

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
@richardlau richardlau force-pushed the richardlau:nointernetdoctests branch from a3d45c1 to 3cb0fed Nov 2, 2019
@nodejs-github-bot

This comment has been minimized.

tools/doc/versions.js Outdated Show resolved Hide resolved
@Trott
Trott approved these changes Nov 3, 2019
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@richardlau richardlau force-pushed the richardlau:nointernetdoctests branch 3 times, most recently from 7d2a1b6 to 3ce1da5 Nov 3, 2019
@devsnek
devsnek approved these changes Nov 3, 2019
@richardlau richardlau added the needs-ci label Nov 3, 2019
@richardlau

This comment has been minimized.

Copy link
Member Author

richardlau commented Nov 3, 2019

ARM builds currently have issues unrelated to this PR (nodejs/build#2028) so holding off rerunning CI until they're resolved.

Copy link
Member

joyeecheung left a comment

LGTM, thanks!

@nodejs-github-bot

This comment has been minimized.

@richardlau richardlau added author ready and removed needs-ci labels Nov 6, 2019
@nodejs-github-bot

This comment has been minimized.

Allow doctool to fallback to use local files if not building a release
build.

PR-URL: #30214
Fixes: #29918
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@richardlau richardlau force-pushed the richardlau:nointernetdoctests branch from 3ce1da5 to 3b124e0 Nov 6, 2019
@richardlau richardlau merged commit 3b124e0 into nodejs:master Nov 6, 2019
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
@richardlau

This comment has been minimized.

Copy link
Member Author

richardlau commented Nov 6, 2019

Landed in 3b124e0.

@richardlau richardlau deleted the richardlau:nointernetdoctests branch Nov 6, 2019
MylesBorins added a commit that referenced this pull request Nov 17, 2019
Allow doctool to fallback to use local files if not building a release
build.

PR-URL: #30214
Fixes: #29918
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Nov 19, 2019
targos added a commit that referenced this pull request Dec 1, 2019
Allow doctool to fallback to use local files if not building a release
build.

PR-URL: #30214
Fixes: #29918
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 9, 2019
MylesBorins added a commit that referenced this pull request Dec 17, 2019
Allow doctool to fallback to use local files if not building a release
build.

PR-URL: #30214
Fixes: #29918
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.