Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: move inactive Collaborators to emeriti #30243

Merged
merged 0 commits into from Nov 6, 2019
Merged

doc: move inactive Collaborators to emeriti #30243

merged 0 commits into from Nov 6, 2019

Conversation

@Trott
Copy link
Member

Trott commented Nov 4, 2019

Move a handful of inactive Collaborators to emeriti.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
@Trott

This comment has been minimized.

Copy link
Member Author

Trott commented Nov 4, 2019

@cjihrig
cjihrig approved these changes Nov 4, 2019
@targos
targos approved these changes Nov 4, 2019
@Trott

This comment has been minimized.

Copy link
Member Author

Trott commented Nov 4, 2019

I think @RReverser should not be moved to emeriti

Based on my email exchange with RReverser prior to opening this PR, they disagree with that assessment and think they should be moved to emeritus. That said, I'm happy to pull them out of this PR if they are having second thoughts.

@trivikr

This comment has been minimized.

Copy link
Member

trivikr commented Nov 4, 2019

Based on my email exchange with RReverser prior to opening this PR, they disagree with that assessment and think they should be moved to emeritus.

I didn't have conversation with RReverser, my suggestion was solely based on activity. They can be moved to emeritus.

@trivikr
trivikr approved these changes Nov 4, 2019
@Trott

This comment has been minimized.

Copy link
Member Author

Trott commented Nov 4, 2019

Based on my email exchange with RReverser prior to opening this PR, they disagree with that assessment and think they should be moved to emeritus.

I didn't have conversation with RReverser, my suggestion was solely based on activity. They can be moved to emeritus.

Sounds good. In light of relatively recent comments from them, I just want to give them the opportunity to say "You know what, keep me around, I want to be able to use my comments to approve/reject changes" or whatever. But yeah, if we don't hear otherwise, let's land this as-is.

@lpinca
lpinca approved these changes Nov 4, 2019
Copy link
Member

mhdawson left a comment

LGTM

@Trott Trott added the author ready label Nov 5, 2019
Copy link
Member

benjamingr left a comment

Thank you :]

@Trott Trott closed this Nov 6, 2019
@Trott Trott force-pushed the Trott:emeriti-2 branch from 8875059 to b6201ab Nov 6, 2019
@Trott

This comment has been minimized.

Copy link
Member Author

Trott commented Nov 6, 2019

Landed in b6201ab

@Trott Trott merged commit b6201ab into nodejs:master Nov 6, 2019
@brendanashworth

This comment has been minimized.

Copy link
Contributor

brendanashworth commented Nov 8, 2019

Thank you!

MylesBorins added a commit that referenced this pull request Nov 17, 2019
Move a handful of inactive Collaborators to emeriti.

PR-URL: #30243
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Nov 19, 2019
targos added a commit that referenced this pull request Dec 1, 2019
Move a handful of inactive Collaborators to emeriti.

PR-URL: #30243
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 9, 2019
MylesBorins added a commit that referenced this pull request Dec 17, 2019
Move a handful of inactive Collaborators to emeriti.

PR-URL: #30243
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.