Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto: fix key requirements in asymmetric cipher #30249

Closed
wants to merge 2 commits into from

Conversation

@tniessen
Copy link
Member

tniessen commented Nov 4, 2019

Fixes: #30237

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Fixes: #30237
@tniessen tniessen added the crypto label Nov 4, 2019
@tniessen tniessen requested a review from bnoordhuis Nov 4, 2019
@nodejs-github-bot

This comment was marked as outdated.

test/parallel/test-crypto-key-objects.js Outdated Show resolved Hide resolved
@nodejs-github-bot

This comment was marked as outdated.

@cjihrig
cjihrig approved these changes Nov 4, 2019
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment has been minimized.

@jasnell
jasnell approved these changes Nov 5, 2019
tniessen added a commit that referenced this pull request Nov 13, 2019
PR-URL: #30249
Fixes: #30237
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@tniessen

This comment has been minimized.

Copy link
Member Author

tniessen commented Nov 13, 2019

Landed in 78dbe74, thanks for reviewing!

@tniessen tniessen closed this Nov 13, 2019
Trott added a commit to Trott/io.js that referenced this pull request Nov 14, 2019
PR-URL: nodejs#30249
Fixes: nodejs#30237
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins added a commit that referenced this pull request Nov 17, 2019
PR-URL: #30249
Fixes: #30237
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.