Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: pull xcode_emulation.py fixes from node-gyp #30272

Closed
wants to merge 2 commits into from

Conversation

@cclauss
Copy link
Contributor

cclauss commented Nov 5, 2019

Fixes: #30129

This change copes several Python 3 fixes from node-gyp's copy of xcode_emulation.py to the /tools copy of that file. In particular, the changes from nodejs/node-gyp#1890 nodejs/node-gyp#1895 nodejs/node-gyp#1932 and nodejs/node-gyp#1939 are contained in this pull request

See #30129 (comment)
FYI: @chrmoritz

Checklist
@cclauss cclauss added the Python label Nov 5, 2019
@cclauss cclauss changed the title tools: pull xcode_emulation.py from node-gyp tools: pull xcode_emulation.py fixes from node-gyp Nov 5, 2019
@chrmoritz

This comment has been minimized.

Copy link

chrmoritz commented Nov 5, 2019

Thanks @cclauss. I'm currently testing also my backport in master...chrmoritz:macosPy3, but this is more complete.

The only thing missing here is a backport of nodejs/node-gyp@a48f09b#diff-a486ea7ed25fd07c6c5a3aee31ed8308, which would be required for making PYTHON=python3 make work too. (But this is currently only breaking the probably small number of users on macOS, who have python on the PATH pointing to a Python 3 instead of system (or whatever) Python 2.)

@ZYSzys
ZYSzys approved these changes Nov 6, 2019
@nodejs-github-bot

This comment has been minimized.

@ZYSzys

This comment has been minimized.

Copy link
Member

ZYSzys commented Nov 6, 2019

Could this be fast-track ?

@nodejs-github-bot

This comment has been minimized.

@danbev
danbev approved these changes Nov 6, 2019
@targos
targos approved these changes Nov 6, 2019
@ChALkeR ChALkeR added the fast-track label Nov 6, 2019
@nodejs-github-bot

This comment has been minimized.

ChALkeR added a commit that referenced this pull request Nov 6, 2019
PR-URL: #30272
Fixes: #30129
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@ChALkeR

This comment has been minimized.

Copy link
Member

ChALkeR commented Nov 6, 2019

Landed in 0673dfc.

@ChALkeR ChALkeR closed this Nov 6, 2019
@cclauss cclauss deleted the cclauss:fix-xcode_emulation.py branch Nov 6, 2019
targos added a commit that referenced this pull request Nov 14, 2019
PR-URL: #30272
Fixes: #30129
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
MylesBorins added a commit that referenced this pull request Nov 17, 2019
PR-URL: #30272
Fixes: #30129
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@BridgeAR BridgeAR mentioned this pull request Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
9 participants
You can’t perform that action at this time.