Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http: rename var to let and const #30279

Closed
wants to merge 3 commits into from
Closed

Conversation

@telenord
Copy link

telenord commented Nov 6, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
telenord
lib/_http_server.js Outdated Show resolved Hide resolved
telenord
@trivikr
trivikr approved these changes Nov 6, 2019
@yorkie
yorkie approved these changes Nov 7, 2019
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@Trott

This comment has been minimized.

Copy link
Member

Trott commented Nov 19, 2019

@telenord Welcome and thanks for the pull request. If you want your GitHub account to linked as the author of these changes, please follow the instructions at https://github.com/nodejs/node/blob/99b1ada/doc/guides/contributing/pull-requests.md#step-1-fork.

@Trott

This comment has been minimized.

Copy link
Member

Trott commented Nov 19, 2019

Landed in 422650a

@Trott Trott closed this Nov 19, 2019
@Trott

This comment has been minimized.

Copy link
Member

Trott commented Nov 19, 2019

Thanks for the contribution! 🎉

Trott added a commit to Trott/io.js that referenced this pull request Nov 19, 2019
* replace var with const
* eliminate unnecessary bytesParsed variable

http: remove bytesParsed var

PR-URL: nodejs#30279
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR added a commit that referenced this pull request Nov 19, 2019
* replace var with const
* eliminate unnecessary bytesParsed variable

http: remove bytesParsed var

PR-URL: #30279
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Nov 19, 2019
targos added a commit that referenced this pull request Dec 1, 2019
* replace var with const
* eliminate unnecessary bytesParsed variable

http: remove bytesParsed var

PR-URL: #30279
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 9, 2019
MylesBorins added a commit that referenced this pull request Dec 17, 2019
* replace var with const
* eliminate unnecessary bytesParsed variable

http: remove bytesParsed var

PR-URL: #30279
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
9 participants
You can’t perform that action at this time.