Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http: http_outgoing rename var to let and const #30284

Closed
wants to merge 1 commit into from

Conversation

@telenord
Copy link

telenord commented Nov 6, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
@addaleax addaleax mentioned this pull request Nov 6, 2019
2 of 4 tasks complete
@ChALkeR
ChALkeR approved these changes Nov 6, 2019
@addaleax addaleax mentioned this pull request Nov 6, 2019
2 of 4 tasks complete
@cjihrig
cjihrig approved these changes Nov 6, 2019
lib/_http_outgoing.js Outdated Show resolved Hide resolved
lib/_http_outgoing.js Outdated Show resolved Hide resolved
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

lib/internal/errors.js Outdated Show resolved Hide resolved
lib/_http_outgoing.js Outdated Show resolved Hide resolved
@gireeshpunathil

This comment has been minimized.

Copy link
Member

gireeshpunathil commented Nov 26, 2019

ping @telenord

@Trott Trott removed the author ready label Dec 6, 2019
@BridgeAR

This comment has been minimized.

Copy link
Member

BridgeAR commented Dec 25, 2019

Ping @telenord

@BridgeAR

This comment has been minimized.

Copy link
Member

BridgeAR commented Dec 26, 2019

@telenord thank you very much for following up on one of the comments. There are some conflicts tough and it would be great if you could rebase this (git fetch upstream && git rebase -i upstream/master && git push --force-with-lease or similar). There is also one more comment about an extra whitespace.

@BridgeAR BridgeAR force-pushed the telenord:http_outgoing branch from 736262a to a10278f Jan 2, 2020
@BridgeAR

This comment has been minimized.

Copy link
Member

BridgeAR commented Jan 2, 2020

I rebased to fix the conflicts and the comment.

@BridgeAR BridgeAR dismissed trivikr’s stale review Jan 2, 2020

Comment addressed. PTAL

@nodejs-github-bot

This comment has been minimized.

@trivikr
trivikr approved these changes Jan 2, 2020
@nodejs-github-bot

This comment has been minimized.

BridgeAR added a commit that referenced this pull request Jan 3, 2020
PR-URL: #30284
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BridgeAR

This comment has been minimized.

Copy link
Member

BridgeAR commented Jan 3, 2020

Landed in 6450f36 🎉

@BridgeAR BridgeAR closed this Jan 3, 2020
BridgeAR added a commit that referenced this pull request Jan 3, 2020
PR-URL: #30284
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Jan 7, 2020
targos added a commit that referenced this pull request Jan 14, 2020
PR-URL: #30284
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos added a commit that referenced this pull request Jan 14, 2020
PR-URL: #30284
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.