Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tls: replace var with let and const #30299

Closed
wants to merge 1 commit into from

Conversation

@Nolikzero
Copy link

Nolikzero commented Nov 6, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Nolik
@cjihrig
cjihrig approved these changes Nov 6, 2019
if (options.honorCipherOrder)
secureOptions |= SSL_OP_CIPHER_SERVER_PREFERENCE;

const c = new SecureContext(options.secureProtocol, secureOptions,
options.minVersion, options.maxVersion);
var i;
var val;
let i;

This comment has been minimized.

Copy link
@trivikr

trivikr Nov 6, 2019

Member

The variable i can be moved inside for loop on lines 107 and 123

for (let i = 0; i < ca.length; ++i) {
for (let i = 0; i < cert.length; ++i) {
var i;
var val;
let i;
let val;

This comment has been minimized.

Copy link
@trivikr

trivikr Nov 6, 2019

Member

The variable val can be made const on lines 108 and 124

const val = ca[i];
const val = cert[i];
@nodejs-github-bot

This comment has been minimized.

Trott added a commit that referenced this pull request Nov 8, 2019
PR-URL: #30299
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@Trott

This comment has been minimized.

Copy link
Member

Trott commented Nov 8, 2019

Landed in 722fc72

@Trott Trott closed this Nov 8, 2019
@Trott

This comment has been minimized.

Copy link
Member

Trott commented Nov 8, 2019

Thanks for the contribution! 🎉

MylesBorins added a commit that referenced this pull request Nov 17, 2019
PR-URL: #30299
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Nov 19, 2019
targos added a commit that referenced this pull request Dec 1, 2019
PR-URL: #30299
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 9, 2019
MylesBorins added a commit that referenced this pull request Dec 17, 2019
PR-URL: #30299
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.