Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: test cover prepare_stack_trace in case of trace is empty #30311

Closed
wants to merge 3 commits into from

Conversation

@telenord
Copy link

telenord commented Nov 6, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
@telenord telenord changed the title test: test cover prepare_stack_trace in case when trace is empty test: test cover prepare_stack_trace in case of trace is empty Nov 6, 2019
@gireeshpunathil

This comment has been minimized.

Copy link
Member

gireeshpunathil commented Nov 21, 2019

@nodejs-github-bot

This comment has been minimized.

@trivikr

This comment has been minimized.

Copy link
Member

trivikr commented Nov 21, 2019

@telenord The email used for the commit is not registered with GitHub.
Either change author info or register the email ID used in the commit with GitHub.

@nodejs-github-bot

This comment has been minimized.

gireeshpunathil added a commit that referenced this pull request Nov 24, 2019
cover prepare_stack_trace in case when trace is empty
PR-URL: #30311
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@gireeshpunathil

This comment has been minimized.

Copy link
Member

gireeshpunathil commented Nov 24, 2019

landed in d90219d, thanks for the contribution!

addaleax added a commit that referenced this pull request Nov 30, 2019
cover prepare_stack_trace in case when trace is empty
PR-URL: #30311
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
targos added a commit that referenced this pull request Dec 1, 2019
cover prepare_stack_trace in case when trace is empty
PR-URL: #30311
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@BridgeAR BridgeAR mentioned this pull request Dec 3, 2019
@BethGriggs BethGriggs mentioned this pull request Dec 9, 2019
MylesBorins added a commit that referenced this pull request Dec 17, 2019
cover prepare_stack_trace in case when trace is empty
PR-URL: #30311
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@BethGriggs BethGriggs mentioned this pull request Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.