Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Negative case for fs Dir class initialisation without handler #30313

Closed
wants to merge 1 commit into from

Conversation

@Di9
Copy link

Di9 commented Nov 6, 2019

Covering the case when init Dir class without passing handler to constructor.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
@cjihrig
cjihrig approved these changes Nov 6, 2019
@trivikr
trivikr approved these changes Nov 6, 2019
Copy link
Member

trivikr left a comment

@Di9 Di9 force-pushed the Di9:test-fs-dir-add branch 2 times, most recently from 67d5ee4 to f08b7fd Nov 6, 2019
@nodejs-github-bot

This comment has been minimized.

@Di9 Di9 force-pushed the Di9:test-fs-dir-add branch from f08b7fd to bafa0a5 Nov 7, 2019
@lpinca
lpinca approved these changes Nov 8, 2019
@Di9 Di9 force-pushed the Di9:test-fs-dir-add branch from bafa0a5 to c3796a1 Nov 10, 2019
Covering the case when init Dir class without passing
handle paramd to constructor.
@Di9 Di9 force-pushed the Di9:test-fs-dir-add branch from c3796a1 to acdbc6c Nov 10, 2019
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@gireeshpunathil

This comment has been minimized.

Copy link
Member

gireeshpunathil commented Nov 26, 2019

the failure in linux-containerized run node-api/test_make_callback/test-async-hooks-gcable is known as in #30648

the windows failure parallel/test-inspector-wait-for-connection is known as in #30619

the windows failure sequential/test-inspector-contexts is known as in #30519

gireeshpunathil added a commit that referenced this pull request Nov 26, 2019
Covering the case when init Dir class without passing
handle paramd to constructor.

PR-URL: #30313
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@gireeshpunathil

This comment has been minimized.

Copy link
Member

gireeshpunathil commented Nov 26, 2019

landed in 8c41b19.

thanks for the contribution!

addaleax added a commit that referenced this pull request Nov 30, 2019
Covering the case when init Dir class without passing
handle paramd to constructor.

PR-URL: #30313
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos added a commit that referenced this pull request Dec 1, 2019
Covering the case when init Dir class without passing
handle paramd to constructor.

PR-URL: #30313
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Dec 3, 2019
@BethGriggs BethGriggs mentioned this pull request Dec 9, 2019
MylesBorins added a commit that referenced this pull request Dec 17, 2019
Covering the case when init Dir class without passing
handle paramd to constructor.

PR-URL: #30313
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.