Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

process: add coverage tests for sourceMapFromDataUrl method #30319

Closed
wants to merge 2 commits into from

Conversation

@Nolikzero
Copy link

Nolikzero commented Nov 6, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
@addaleax addaleax requested a review from bcoe Nov 6, 2019
@addaleax addaleax added the source maps label Nov 6, 2019
@bcoe
bcoe approved these changes Nov 6, 2019
Copy link
Member

bcoe left a comment

these look like good tests to me 👍 did you confirm that they increase coverage?

@@ -116,6 +116,36 @@ function nextdir() {
);
}

{

This comment has been minimized.

Copy link
@bcoe

bcoe Nov 6, 2019

Member

could we add a comment above both of these blocks that describes the purpose of the test, e.g.,

"base64 encoding error does not crash application".

This comment has been minimized.

Copy link
@Trott

Trott Nov 8, 2019

Member

I took the liberty of adding two comments. LGTY?

@trivikr
trivikr approved these changes Nov 8, 2019
@Trott Trott force-pushed the Nolikzero:source-maps-tests branch from 33f0456 to 164fadf Nov 8, 2019
@nodejs-github-bot

This comment has been minimized.

@shisama
shisama approved these changes Nov 9, 2019
@Trott

This comment has been minimized.

Copy link
Member

Trott commented Nov 9, 2019

@Nolikzero FWIW, GitHub can't link your account to your contributions. See https://github.com/nodejs/node/blob/99b1ada/doc/guides/contributing/pull-requests.md#step-1-fork to fix. (Basically, you'll need to add the email in your commit to https://github.com/settings/emails.)

Trott added a commit that referenced this pull request Nov 9, 2019
PR-URL: #30319
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Coe <bencoe@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
@Trott

This comment has been minimized.

Copy link
Member

Trott commented Nov 9, 2019

Landed in eb77321

Thanks for the contribution! 🎉

@Trott Trott closed this Nov 9, 2019
MylesBorins added a commit that referenced this pull request Nov 17, 2019
PR-URL: #30319
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Coe <bencoe@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Nov 19, 2019
targos added a commit that referenced this pull request Dec 1, 2019
PR-URL: #30319
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Coe <bencoe@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 9, 2019
MylesBorins added a commit that referenced this pull request Dec 17, 2019
PR-URL: #30319
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Coe <bencoe@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.