Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc,meta: remove wait period for npm pull requests #30329

Merged
merged 1 commit into from Nov 10, 2019

Conversation

@Trott
Copy link
Member

Trott commented Nov 8, 2019

Treat npm pull requests like all other pull requests. Remove special
extended wait period for landing.

@nodejs/npm

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
@Trott Trott added npm and removed doc labels Nov 8, 2019
@Trott

This comment has been minimized.

Copy link
Member Author

Trott commented Nov 8, 2019

@Trott Trott added the author ready label Nov 8, 2019
One week after the "latest" release has been promoted, it can land on master
assuming no major regressions are found. There are no additional constraints
for Semver-Major releases.

This comment has been minimized.

Copy link
@gireeshpunathil

gireeshpunathil Nov 8, 2019

Member

@Trott - what would be an advantage of doing this? IMO a one week grace period is justified as a resiliency and quality measure.

This comment has been minimized.

Copy link
@Trott

Trott Nov 8, 2019

Author Member

@gireeshpunathil I think it makes sense to withhold it from releases, but I'm less certain that there's much advantage to delaying it landing on master. There was relevant discussion about this in #29922. In that discussion, there seem to be a lot of people (especially if you include emoji reactions) in favor of getting rid of the delay and treating npm PRs like other PRs. But I'm totally OK if someone thinks this goes too far and blocks this change. Ultimately, I'm comfortable with changing it because we can always change the rule back.

@targos
targos approved these changes Nov 8, 2019
@Trott

This comment has been minimized.

Copy link
Member Author

Trott commented Nov 8, 2019

Going to @-mention @nodejs/tsc here as it seems like the right thing to do for a process change like this.

@trivikr
trivikr approved these changes Nov 8, 2019
@lpinca
lpinca approved these changes Nov 8, 2019
Treat npm pull requests like all other pull requests. Remove special
extended wait period for landing.

PR-URL: #30329
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Trott Trott force-pushed the Trott:remove-npm-wait-time branch from 026d819 to 5f9794e Nov 10, 2019
@Trott Trott merged commit 5f9794e into nodejs:master Nov 10, 2019
@Trott

This comment has been minimized.

Copy link
Member Author

Trott commented Nov 10, 2019

Landed in 5f9794e

MylesBorins added a commit that referenced this pull request Nov 17, 2019
Treat npm pull requests like all other pull requests. Remove special
extended wait period for landing.

PR-URL: #30329
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Nov 19, 2019
targos added a commit that referenced this pull request Dec 1, 2019
Treat npm pull requests like all other pull requests. Remove special
extended wait period for landing.

PR-URL: #30329
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 9, 2019
MylesBorins added a commit that referenced this pull request Dec 17, 2019
Treat npm pull requests like all other pull requests. Remove special
extended wait period for landing.

PR-URL: #30329
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.