Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc,meta: allow Travis results for doc/comment changes #30330

Merged
merged 1 commit into from Nov 10, 2019

Conversation

@Trott
Copy link
Member

Trott commented Nov 8, 2019

Permit the use of Travis CI results for pull requests that only change
documentation or comments. This also removes
node-test-pull-request-lite-pipeline from the documentation. Efforts to
move all CI jobs to pipelines have stalled and it's not clear that our
current Jenkins admins are enthusiastic about pipelines.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
COLLABORATOR_GUIDE.md Outdated Show resolved Hide resolved
@Trott

This comment has been minimized.

Copy link
Member Author

Trott commented Nov 8, 2019

@gireeshpunathil

This comment has been minimized.

Copy link
Member

gireeshpunathil commented Nov 8, 2019

@Trott - does this change also render node-test-pull-request-lite-pipeline unused and candidate for retire?

@Trott

This comment has been minimized.

Copy link
Member Author

Trott commented Nov 8, 2019

@Trott - does this change also render node-test-pull-request-lite-pipeline unused and candidate for retire?

Possibly. We can always keep it around for a few months to see if people still find uses for it or not. And ultimately, the Build WG can decide if having it is a maintenance burden or security risk and get rid of it, or they can decide that it costs little to keep it.

@Trott Trott added the author ready label Nov 8, 2019
@Trott

This comment has been minimized.

Copy link
Member Author

Trott commented Nov 8, 2019

Going to @-mention @nodejs/tsc here as it seems like the right thing to do for a process change like this.

@trivikr
trivikr approved these changes Nov 8, 2019
@cjihrig
cjihrig approved these changes Nov 8, 2019
@lpinca
lpinca approved these changes Nov 8, 2019
@Trott

This comment has been minimized.

Copy link
Member Author

Trott commented Nov 10, 2019

Permit the use of Travis CI results for pull requests that only change
documentation or comments. This also removes
node-test-pull-request-lite-pipeline from the documentation. Efforts to
move all CI jobs to pipelines have stalled and it's not clear that our
current Jenkins admins are enthusiastic about pipelines.

PR-URL: #30330
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Trott Trott force-pushed the Trott:travis-for-docs branch from 5e9dc4a to e44d73f Nov 10, 2019
@Trott Trott merged commit e44d73f into nodejs:master Nov 10, 2019
1 check failed
1 check failed
Travis CI - Pull Request Build Created
Details
@Trott

This comment has been minimized.

Copy link
Member Author

Trott commented Nov 10, 2019

Landed in e44d73f

MylesBorins added a commit that referenced this pull request Nov 17, 2019
Permit the use of Travis CI results for pull requests that only change
documentation or comments. This also removes
node-test-pull-request-lite-pipeline from the documentation. Efforts to
move all CI jobs to pipelines have stalled and it's not clear that our
current Jenkins admins are enthusiastic about pipelines.

PR-URL: #30330
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Nov 19, 2019
targos added a commit that referenced this pull request Dec 1, 2019
Permit the use of Travis CI results for pull requests that only change
documentation or comments. This also removes
node-test-pull-request-lite-pipeline from the documentation. Efforts to
move all CI jobs to pipelines have stalled and it's not clear that our
current Jenkins admins are enthusiastic about pipelines.

PR-URL: #30330
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 9, 2019
@richardlau richardlau mentioned this pull request Dec 16, 2019
MylesBorins added a commit that referenced this pull request Dec 17, 2019
Permit the use of Travis CI results for pull requests that only change
documentation or comments. This also removes
node-test-pull-request-lite-pipeline from the documentation. Efforts to
move all CI jobs to pipelines have stalled and it's not clear that our
current Jenkins admins are enthusiastic about pipelines.

PR-URL: #30330
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.