Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix test-benchmark-cluster #30342

Merged
merged 0 commits into from Nov 9, 2019
Merged

test: fix test-benchmark-cluster #30342

merged 0 commits into from Nov 9, 2019

Conversation

@Trott
Copy link
Member

Trott commented Nov 9, 2019

test-benchmark-cluster needs to account for an option added in 973f324.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@nodejs-github-bot

This comment has been minimized.

@Trott

This comment has been minimized.

Copy link
Member Author

Trott commented Nov 9, 2019

This fixes the nightly node-daily-master CI job, so I'd like to fast-track it. 👍 if you're a Collaborator and you approve.

@Trott Trott added the fast-track label Nov 9, 2019
@cjihrig
cjihrig approved these changes Nov 9, 2019
@Trott Trott added the author ready label Nov 9, 2019
@ZYSzys
ZYSzys approved these changes Nov 9, 2019
@lpinca
lpinca approved these changes Nov 9, 2019
@Trott

This comment has been minimized.

Copy link
Member Author

Trott commented Nov 9, 2019

Landed in acd35d9

@Trott Trott closed this Nov 9, 2019
@Trott Trott reopened this Nov 9, 2019
@Trott Trott merged commit acd35d9 into nodejs:master Nov 9, 2019
@Trott Trott force-pushed the Trott:fix-cluster-test branch from 46fa119 to acd35d9 Nov 9, 2019
MylesBorins added a commit that referenced this pull request Nov 17, 2019
test-benchmark-cluster needs to account for an option added in 973f324.

PR-URL: #30342
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Nov 19, 2019
targos added a commit that referenced this pull request Dec 1, 2019
test-benchmark-cluster needs to account for an option added in 973f324.

PR-URL: #30342
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 9, 2019
MylesBorins added a commit that referenced this pull request Dec 17, 2019
test-benchmark-cluster needs to account for an option added in 973f324.

PR-URL: #30342
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.