Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

console: remove non-existant methods from docs #30346

Conversation

@SimonSchick
Copy link
Contributor

SimonSchick commented Nov 10, 2019

Checklist

It seems these methods are not present anymore, not even with --inspect so I propose removing these docs.

@SimonSchick SimonSchick force-pushed the SimonSchick:docs/remove-dead-inspector-methods branch from 22703ab to 1bceb10 Nov 10, 2019
@lpinca
lpinca approved these changes Nov 10, 2019
@SimonSchick SimonSchick force-pushed the SimonSchick:docs/remove-dead-inspector-methods branch 2 times, most recently from df39117 to 8d29657 Nov 10, 2019
@SimonSchick

This comment has been minimized.

Copy link
Contributor Author

SimonSchick commented Nov 10, 2019

Fixed lint and commit message.

@SimonSchick SimonSchick changed the title docs, lib: remove non-existant methods console: remove non-existant methods from docs Nov 10, 2019
@lpinca

This comment has been minimized.

Copy link
Member

lpinca commented Nov 10, 2019

@SimonSchick I think doc: is more appropriate as subsystem in commit title.

@SimonSchick

This comment has been minimized.

Copy link
Contributor Author

SimonSchick commented Nov 10, 2019

Ah, I tried to use docs before but I guess it needs to be singular.

@SimonSchick SimonSchick force-pushed the SimonSchick:docs/remove-dead-inspector-methods branch from 8d29657 to 5e7d211 Nov 10, 2019
@danbev

This comment has been minimized.

@danbev danbev added the author ready label Nov 12, 2019
danbev added a commit that referenced this pull request Nov 13, 2019
PR-URL: #30346
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@danbev

This comment has been minimized.

Copy link
Member

danbev commented Nov 13, 2019

Landed in 0e964a7.

@danbev danbev closed this Nov 13, 2019
Trott added a commit to Trott/io.js that referenced this pull request Nov 14, 2019
PR-URL: nodejs#30346
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins added a commit that referenced this pull request Nov 17, 2019
PR-URL: #30346
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@SimonSchick SimonSchick mentioned this pull request Nov 18, 2019
8 of 9 tasks complete
@BridgeAR BridgeAR mentioned this pull request Nov 19, 2019
targos added a commit that referenced this pull request Dec 1, 2019
PR-URL: #30346
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 9, 2019
MylesBorins added a commit that referenced this pull request Dec 17, 2019
PR-URL: #30346
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.