Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: remove "multiple variants" from BUILDING.md #30366

Merged
merged 0 commits into from Nov 14, 2019
Merged

Conversation

@Trott
Copy link
Member

Trott commented Nov 12, 2019

The statement that tests for tier 1 platforms are run on multiple
variants is not true. We usually only run on one variants of macOS.
Remove "multiple", which simplifies and clarifies the statements anyway.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
@mscdex

This comment has been minimized.

Copy link
Contributor

mscdex commented Nov 12, 2019

s/one variants/one variant/ in commit message

@Trott

This comment has been minimized.

Copy link
Member Author

Trott commented Nov 12, 2019

s/one variants/one variant/ in commit message

Thanks. Fixed.

@Trott Trott force-pushed the Trott:multiple branch from b333e65 to c5e4644 Nov 12, 2019
@Trott Trott added the author ready label Nov 13, 2019
@Trott Trott force-pushed the Trott:multiple branch 4 times, most recently from 4946fbe to 86516c3 Nov 14, 2019
@Trott Trott closed this Nov 14, 2019
@Trott Trott force-pushed the Trott:multiple branch from 86516c3 to c71b89e Nov 14, 2019
@Trott Trott merged commit c71b89e into nodejs:master Nov 14, 2019
1 check passed
1 check passed
Travis CI - Branch Build Passed
Details
@Trott

This comment has been minimized.

Copy link
Member Author

Trott commented Nov 14, 2019

Landed in c71b89e

MylesBorins added a commit that referenced this pull request Nov 17, 2019
The statement that tests for tier 1 platforms are run on multiple
variants is not true. We usually only run on one variant of macOS.
Remove "multiple", which simplifies and clarifies the statements anyway.

PR-URL: #30366
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR BridgeAR mentioned this pull request Nov 19, 2019
targos added a commit that referenced this pull request Dec 1, 2019
The statement that tests for tier 1 platforms are run on multiple
variants is not true. We usually only run on one variant of macOS.
Remove "multiple", which simplifies and clarifies the statements anyway.

PR-URL: #30366
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BethGriggs BethGriggs mentioned this pull request Dec 9, 2019
MylesBorins added a commit that referenced this pull request Dec 17, 2019
The statement that tests for tier 1 platforms are run on multiple
variants is not true. We usually only run on one variant of macOS.
Remove "multiple", which simplifies and clarifies the statements anyway.

PR-URL: #30366
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BethGriggs BethGriggs mentioned this pull request Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.