doc: improve doc Http2Stream: FrameError, Timeout and Trailers #30373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add line in doc/http2.md for 'frameError', 'timeout', 'trailers' events which tell readers that these events except any arguments or doesn't. Fixes: nodejs/help#877
nodejs-github-bot
added
doc
Trott
reviewed
Nov 12, 2019
Add arguments in doc/http2.md for 'trailers' event which tell readers that 'trailers' event except arguments. Fixes: nodejs/help#877
jasnell
approved these changes
Nov 14, 2019
gireeshpunathil
approved these changes
Nov 25, 2019
gireeshpunathil
added
the
author ready
|
ping @Trott - PTAL! |
BridgeAR
approved these changes
Dec 9, 2019
BridgeAR
pushed a commit
that referenced
this pull request
Dec 9, 2019
Document arguments for the 'frameError', 'timeout' and 'trailers' event. PR-URL: #30373 Fixes: nodejs/help#877 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
|
This seemed good to go (the comment seemed properly addressed to me). Landed in caa96dd 🎉 |
targos
pushed a commit
that referenced
this pull request
Dec 10, 2019
Document arguments for the 'frameError', 'timeout' and 'trailers' event. PR-URL: #30373 Fixes: nodejs/help#877 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
targos
pushed a commit
that referenced
this pull request
Jan 14, 2020
Document arguments for the 'frameError', 'timeout' and 'trailers' event. PR-URL: #30373 Fixes: nodejs/help#877 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 6, 2020
Document arguments for the 'frameError', 'timeout' and 'trailers' event. PR-URL: #30373 Fixes: nodejs/help#877 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in doc/http2.md for 'frameError', 'timeout', 'trailers' events
which tell readers that these events except any arguments or doesn't.
Fixes: nodejs/help#877
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes