Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: replace var with let/const #30394

Closed

Conversation

@kresimirfranin
Copy link

kresimirfranin commented Nov 12, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
@nodejs-github-bot

This comment has been minimized.

@BridgeAR

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@gireeshpunathil

This comment has been minimized.

Copy link
Member

gireeshpunathil commented Nov 25, 2019

@kresimirfranin - this needs a rebase (the upstream is changed since the time you took a snapshot).

@addaleax addaleax removed the author ready label Nov 29, 2019
@BridgeAR

This comment has been minimized.

Copy link
Member

BridgeAR commented Dec 25, 2019

@kresimirfranin kresimirfranin force-pushed the kresimirfranin:node_conf_var_to_let_zlib branch from 65e26c6 to 808169b Dec 28, 2019
@kresimirfranin

This comment has been minimized.

Copy link
Author

kresimirfranin commented Dec 28, 2019

@gireeshpunathil @BridgeAR sry, done

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@gireeshpunathil

This comment has been minimized.

Copy link
Member

gireeshpunathil commented Dec 28, 2019

the only failure in AIX sequential/test-http2-settings-flood is known as in #31107

gireeshpunathil added a commit that referenced this pull request Dec 28, 2019
PR-URL: #30394
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@gireeshpunathil

This comment has been minimized.

Copy link
Member

gireeshpunathil commented Dec 28, 2019

landed in a412a97 , thanks for the contribution!

@Trott

This comment has been minimized.

Copy link
Member

Trott commented Dec 29, 2019

For code-and-learn commits like this one, it would be good for us to make a habit of updating the commit message when landing. This one says lib and makes no mention of zlib so it appears more significant than it is until you look at the actual change.

I'll try to be better about flagging these things myself, although I didn't review this one at all.

@gireeshpunathil

This comment has been minimized.

Copy link
Member

gireeshpunathil commented Dec 29, 2019

@Trott - acknowledged!

BridgeAR added a commit that referenced this pull request Jan 3, 2020
PR-URL: #30394
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Jan 7, 2020
targos added a commit that referenced this pull request Jan 14, 2020
PR-URL: #30394
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos added a commit that referenced this pull request Jan 14, 2020
PR-URL: #30394
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
10 participants
You can’t perform that action at this time.