Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util: Use let instead of var for util/inspect.js #30399

Closed
wants to merge 3 commits into from

Conversation

@lmammino
Copy link
Contributor

lmammino commented Nov 12, 2019

Style changes: use let instead of var in lib/internal/util/inspect.js

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@BridgeAR

This comment has been minimized.

@lmammino

This comment has been minimized.

Copy link
Contributor Author

lmammino commented Nov 14, 2019

Ci seems to be failing because the first letter (after subsystem) in my commit message is uppercase. I'll try to fix this with an amend commit...

@lmammino lmammino force-pushed the lmammino:fix/removes-var-from-inspect branch from 8c7a7df to a2dd360 Nov 14, 2019
@nodejs-github-bot

This comment has been minimized.

@gireeshpunathil

This comment has been minimized.

Copy link
Member

gireeshpunathil commented Nov 25, 2019

Linux-containered (ubuntu1804_sharedlibs_debug_x64): https://ci.nodejs.org/job/node-test-commit-linux-containered/16157/

@lmammino

This comment has been minimized.

Copy link
Contributor Author

lmammino commented Nov 25, 2019

Still seeing some failures in the CI, can someone guide me on what's wrong and how to resolve any pending issue?

@gireeshpunathil

This comment has been minimized.

Copy link
Member

gireeshpunathil commented Nov 25, 2019

last run (linux-containerized) was aborted due to infra issues. new run:
https://ci.nodejs.org/job/node-test-commit-linux-containered/16165/

@gireeshpunathil

This comment has been minimized.

@gireeshpunathil

This comment has been minimized.

Copy link
Member

gireeshpunathil commented Nov 26, 2019

the linux-containerized failure parallel/test-domain-error-types is known as in #30498

gireeshpunathil added a commit that referenced this pull request Nov 26, 2019
PR-URL: #30399
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@gireeshpunathil

This comment has been minimized.

Copy link
Member

gireeshpunathil commented Nov 26, 2019

landed in 3f59704.

thanks for the contribution!

@lmammino

This comment has been minimized.

Copy link
Contributor Author

lmammino commented Nov 26, 2019

Thank you all for helping me with this :)

addaleax added a commit that referenced this pull request Nov 30, 2019
PR-URL: #30399
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos added a commit that referenced this pull request Dec 1, 2019
PR-URL: #30399
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Dec 3, 2019
@BethGriggs BethGriggs mentioned this pull request Dec 9, 2019
MylesBorins added a commit that referenced this pull request Dec 17, 2019
PR-URL: #30399
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.