Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib/timers.js: replace var with let/const #30404

Closed
wants to merge 1 commit into from

Conversation

@TimEmbrechts
Copy link

TimEmbrechts commented Nov 12, 2019

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows
@@ -118,7 +118,7 @@ function setTimeout(callback, after, arg1, arg2, arg3) {
throw new ERR_INVALID_CALLBACK(callback);
}

var i, args;
let i, args;

This comment has been minimized.

Copy link
@trivikr

trivikr Nov 13, 2019

Member

nit: move i to line 135?

for (let i = 5; i < arguments.length; i++) {
@@ -164,7 +164,7 @@ function setInterval(callback, repeat, arg1, arg2, arg3) {
throw new ERR_INVALID_CALLBACK(callback);
}

var i, args;
let i, args;

This comment has been minimized.

Copy link
@trivikr

trivikr Nov 13, 2019

Member

nit: move i to line 181?

for (let i = 5; i < arguments.length; i++) {
@@ -248,7 +248,7 @@ function setImmediate(callback, arg1, arg2, arg3) {
throw new ERR_INVALID_CALLBACK(callback);
}

var i, args;
let i, args;

This comment has been minimized.

Copy link
@trivikr

trivikr Nov 13, 2019

Member

nit: move i to line 264?

for (let i = 4; i < arguments.length; i++) {
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

gireeshpunathil added a commit that referenced this pull request Nov 24, 2019
PR-URL: #30404
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@gireeshpunathil

This comment has been minimized.

Copy link
Member

gireeshpunathil commented Nov 24, 2019

landed in ee81bce, thanks for the contribution!

addaleax added a commit that referenced this pull request Nov 30, 2019
PR-URL: #30404
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos added a commit that referenced this pull request Dec 1, 2019
PR-URL: #30404
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Dec 3, 2019
@BethGriggs BethGriggs mentioned this pull request Dec 9, 2019
MylesBorins added a commit that referenced this pull request Dec 17, 2019
PR-URL: #30404
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.