Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http2: replace var with let/const #30417

Closed
wants to merge 3 commits into from
Closed

http2: replace var with let/const #30417

wants to merge 3 commits into from

Conversation

@pc3b3r
Copy link
Contributor

pc3b3r commented Nov 12, 2019

Changed var to let and const on util. Keeping var on for loops.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
lib/internal/http2/util.js Outdated Show resolved Hide resolved
lib/internal/http2/util.js Outdated Show resolved Hide resolved
lib/internal/http2/util.js Outdated Show resolved Hide resolved
lib/internal/http2/util.js Outdated Show resolved Hide resolved
lib/internal/http2/util.js Outdated Show resolved Hide resolved
lib/internal/http2/util.js Outdated Show resolved Hide resolved
lib/internal/http2/util.js Outdated Show resolved Hide resolved
lib/internal/http2/util.js Outdated Show resolved Hide resolved
lib/internal/http2/util.js Outdated Show resolved Hide resolved
Co-Authored-By: James M Snell <jasnell@gmail.com>
lib/internal/http2/util.js Outdated Show resolved Hide resolved
Co-Authored-By: James M Snell <jasnell@gmail.com>
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

Trott added a commit that referenced this pull request Nov 23, 2019
PR-URL: #30417
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@Trott

This comment has been minimized.

Copy link
Member

Trott commented Nov 23, 2019

Landed in 0271f1b.

Thanks for the contribution! 🎉

@Trott Trott closed this Nov 23, 2019
addaleax added a commit that referenced this pull request Nov 30, 2019
PR-URL: #30417
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
targos added a commit that referenced this pull request Dec 1, 2019
PR-URL: #30417
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@BridgeAR BridgeAR mentioned this pull request Dec 3, 2019
@BethGriggs BethGriggs mentioned this pull request Dec 9, 2019
MylesBorins added a commit that referenced this pull request Dec 17, 2019
PR-URL: #30417
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@BethGriggs BethGriggs mentioned this pull request Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.