Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use spread object #30423

Closed
wants to merge 1 commit into from
Closed

Conversation

@franher
Copy link
Member

franher commented Nov 12, 2019

Object.assign() can be replaced by spread objects { ... }

Refs: https://eslint.org/docs/rules/prefer-object-spread

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
@franher

This comment has been minimized.

Copy link
Member Author

franher commented Nov 12, 2019

@jasnell I will fix the linting errors and commit the changes. I have run make lint-js-fix but no errors were shown initially.

Thank you for your review

@franher

This comment has been minimized.

Copy link
Member Author

franher commented Nov 12, 2019

Committed the fix on 16280f9

@franher franher force-pushed the franher:style-spread-over-assign branch from 16280f9 to 868ffba Nov 12, 2019
@franher franher requested a review from jasnell Nov 13, 2019
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@gireeshpunathil

This comment has been minimized.

Copy link
Member

gireeshpunathil commented Nov 25, 2019

@franher - this needs a rebase, thanks

@addaleax addaleax removed the author ready label Nov 29, 2019
@Trott
Trott approved these changes Dec 4, 2019
@BridgeAR

This comment has been minimized.

Copy link
Member

BridgeAR commented Dec 25, 2019

Ping @franher

Object.assign() can be replaced by spread objects

Refs: https://eslint.org/docs/rules/prefer-object-spread
@BridgeAR BridgeAR force-pushed the franher:style-spread-over-assign branch from 868ffba to f69937d Jan 2, 2020
@nodejs-github-bot

This comment has been minimized.

BridgeAR added a commit that referenced this pull request Jan 3, 2020
Object.assign() can be replaced by spread objects

PR-URL: #30423
Refs: https://eslint.org/docs/rules/prefer-object-spread
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BridgeAR

This comment has been minimized.

Copy link
Member

BridgeAR commented Jan 3, 2020

Landed in c52ebc0 🎉

@BridgeAR BridgeAR closed this Jan 3, 2020
BridgeAR added a commit that referenced this pull request Jan 3, 2020
Object.assign() can be replaced by spread objects

PR-URL: #30423
Refs: https://eslint.org/docs/rules/prefer-object-spread
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Jan 7, 2020
targos added a commit that referenced this pull request Jan 14, 2020
Object.assign() can be replaced by spread objects

PR-URL: #30423
Refs: https://eslint.org/docs/rules/prefer-object-spread
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
9 participants
You can’t perform that action at this time.