Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change var declarations to let and const #30445

Closed

Conversation

@Xavier-Redondo
Copy link
Contributor

Xavier-Redondo commented Nov 12, 2019

Checklist
  • --> to be precise i have run make -j4 test-only because make -j4 test gave error related to test-doc. this happened before and after making my changes.
@trivikr

This comment has been minimized.

Copy link
Member

trivikr commented Nov 13, 2019

lib/url.js was updated in #30281

@nodejs-github-bot

This comment has been minimized.

@BridgeAR

This comment has been minimized.

Copy link
Member

BridgeAR commented Nov 13, 2019

@trivikr I believe it should not cause any issues to merge the other PR first and to land this afterwards. If the changes are identical, there should not be any conflicts.

@nodejs-github-bot

This comment has been minimized.

gireeshpunathil added a commit that referenced this pull request Nov 17, 2019
PR-URL: #30445
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@gireeshpunathil

This comment has been minimized.

Copy link
Member

gireeshpunathil commented Nov 17, 2019

landed in b6c407b , thanks for the contribution!

BridgeAR added a commit that referenced this pull request Nov 19, 2019
PR-URL: #30445
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR BridgeAR mentioned this pull request Nov 19, 2019
targos added a commit that referenced this pull request Dec 1, 2019
PR-URL: #30445
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BethGriggs BethGriggs mentioned this pull request Dec 9, 2019
MylesBorins added a commit that referenced this pull request Dec 17, 2019
PR-URL: #30445
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BethGriggs BethGriggs mentioned this pull request Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.