Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: handle undefined default_configuration #30465

Closed

Conversation

@codebytere
Copy link
Member

codebytere commented Nov 13, 2019

This PR adds a check for process.config.target_defaults being undefined, as it is Electron's case, and ensures that the buildType is set to a default value of Release should it not be defined.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@nodejs-github-bot

This comment has been minimized.

test/common/index.js Outdated Show resolved Hide resolved
@codebytere codebytere force-pushed the codebytere:handle-unset-defaultconfiguration branch from fe70071 to 7b72997 Nov 13, 2019
@codebytere codebytere requested a review from trivikr Nov 13, 2019
@codebytere

This comment has been minimized.

Copy link
Member Author

codebytere commented Nov 15, 2019

@trivikr your suggestion failed lint:

/home/travis/build/nodejs/node/test/common/index.js
  122:4  error  '?' should be placed at the end of the line  operator-linebreak
  123:4  error  ':' should be placed at the end of the line  operator-linebreak

are we fine for me to move back to the previous format?

I could also do this:

const buildType = process.config.target_defaults ?
  process.config.target_defaults.default_configuration :
  'Release';

i'm fairly un-opinionated on this front ¯\_(ツ)_/¯

@trivikr

This comment has been minimized.

Copy link
Member

trivikr commented Nov 15, 2019

Sure, this format works

const buildType = process.config.target_defaults ?
  process.config.target_defaults.default_configuration :
  'Release';

I'd posted my review as a nit, suggesting it's optional.

@codebytere codebytere force-pushed the codebytere:handle-unset-defaultconfiguration branch from 7b72997 to 74cf1cd Nov 16, 2019
@nodejs-github-bot

This comment has been minimized.

@codebytere

This comment has been minimized.

Copy link
Member Author

codebytere commented Nov 18, 2019

Landed in 70281ce

codebytere added a commit that referenced this pull request Nov 18, 2019
PR-URL: #30465
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@codebytere codebytere closed this Nov 18, 2019
@codebytere codebytere deleted the codebytere:handle-unset-defaultconfiguration branch Nov 18, 2019
BridgeAR added a commit that referenced this pull request Nov 19, 2019
PR-URL: #30465
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Nov 19, 2019
targos added a commit that referenced this pull request Dec 1, 2019
PR-URL: #30465
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 9, 2019
MylesBorins added a commit that referenced this pull request Dec 17, 2019
PR-URL: #30465
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 23, 2019
codebytere added a commit to electron/electron that referenced this pull request Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
9 participants
You can’t perform that action at this time.