Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: store cache on timed out builds on Travis #30469

Merged
merged 2 commits into from Nov 17, 2019
Merged

Conversation

@richardlau
Copy link
Member

richardlau commented Nov 13, 2019

Building Node.js without a ccache cache takes longer than the 50 minute
Travis time limit
for jobs for public repositories. To mitigate this we
added a job to compile V8 on the basis that in the worst case it would
complete within 50 minutes and provide a cache that could be used by a
restarted Compile Node.js job.

Recent PRs have exceeded the 50 minute time limit for the Compile V8
job. When Travis times out a build the cache is not stored.

This commit drops the Compile V8 job and adds a manual timeout to the
Compile Node.js job which will allow the cache to be stored and used
in restarts of the job.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
@richardlau

This comment has been minimized.

@richardlau

This comment has been minimized.

Copy link
Member Author

richardlau commented Nov 13, 2019

Here's an example job log where the timeout is hit and the cache stored: https://travis-ci.com/richardlau/node-1/jobs/256193795 (and shows --preserve-status exits with 143 and not 124 (without --preserve-status) -- fixup pushed).

@richardlau

This comment has been minimized.

COLLABORATOR_GUIDE.md Outdated Show resolved Hide resolved
COLLABORATOR_GUIDE.md Outdated Show resolved Hide resolved
@richardlau

This comment has been minimized.

Copy link
Member Author

richardlau commented Nov 17, 2019

Fixup up docs based on suggestions from @Trott.

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4075/

richardlau added 2 commits Nov 13, 2019
Building Node.js without a ccache cache takes longer than the 50 minute
Travis time limit for jobs for public repositories. To mitigate this we
added a job to compile V8 on the basis that in the worst case it would
complete within 50 minutes and provide a cache that could be used by a
restarted `Compile Node.js` job.

Recent PRs have exceeded the 50 minute time limit for the `Compile V8`
job. When Travis times out a build the cache is not stored.

This commit drops the `Compile V8` job and adds a manual timeout to the
`Compile Node.js` job which will allow the cache to be stored and used
in restarts of the job.

PR-URL: #30469
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
PR-URL: #30469
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
@richardlau richardlau force-pushed the richardlau:travis branch from d9f91ff to 3e2b68a Nov 17, 2019
@richardlau richardlau merged commit 3e2b68a into nodejs:master Nov 17, 2019
1 of 2 checks passed
1 of 2 checks passed
Travis CI - Branch Build Created
Details
Travis CI - Pull Request Build Passed
Details
@richardlau

This comment has been minimized.

Copy link
Member Author

richardlau commented Nov 17, 2019

Landed in 722f958...3e2b68a

BridgeAR added a commit that referenced this pull request Nov 19, 2019
Building Node.js without a ccache cache takes longer than the 50 minute
Travis time limit for jobs for public repositories. To mitigate this we
added a job to compile V8 on the basis that in the worst case it would
complete within 50 minutes and provide a cache that could be used by a
restarted `Compile Node.js` job.

Recent PRs have exceeded the 50 minute time limit for the `Compile V8`
job. When Travis times out a build the cache is not stored.

This commit drops the `Compile V8` job and adds a manual timeout to the
`Compile Node.js` job which will allow the cache to be stored and used
in restarts of the job.

PR-URL: #30469
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
BridgeAR added a commit that referenced this pull request Nov 19, 2019
PR-URL: #30469
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Nov 19, 2019
@srl295 srl295 mentioned this pull request Nov 22, 2019
1 of 4 tasks complete
targos added a commit that referenced this pull request Dec 1, 2019
Building Node.js without a ccache cache takes longer than the 50 minute
Travis time limit for jobs for public repositories. To mitigate this we
added a job to compile V8 on the basis that in the worst case it would
complete within 50 minutes and provide a cache that could be used by a
restarted `Compile Node.js` job.

Recent PRs have exceeded the 50 minute time limit for the `Compile V8`
job. When Travis times out a build the cache is not stored.

This commit drops the `Compile V8` job and adds a manual timeout to the
`Compile Node.js` job which will allow the cache to be stored and used
in restarts of the job.

PR-URL: #30469
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
targos added a commit that referenced this pull request Dec 1, 2019
PR-URL: #30469
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 9, 2019
MylesBorins added a commit that referenced this pull request Dec 17, 2019
Building Node.js without a ccache cache takes longer than the 50 minute
Travis time limit for jobs for public repositories. To mitigate this we
added a job to compile V8 on the basis that in the worst case it would
complete within 50 minutes and provide a cache that could be used by a
restarted `Compile Node.js` job.

Recent PRs have exceeded the 50 minute time limit for the `Compile V8`
job. When Travis times out a build the cache is not stored.

This commit drops the `Compile V8` job and adds a manual timeout to the
`Compile Node.js` job which will allow the cache to be stored and used
in restarts of the job.

PR-URL: #30469
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
MylesBorins added a commit that referenced this pull request Dec 17, 2019
PR-URL: #30469
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.