Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: adds NO_COLOR to assert doc page #30483

Conversation

@shobhitchittora
Copy link
Contributor

shobhitchittora commented Nov 14, 2019

Adding NO_COLOR environment variable to disable colors to the assert docs.

Refs: #30484

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
doc/api/assert.md Outdated Show resolved Hide resolved
@shobhitchittora

This comment has been minimized.

Copy link
Contributor Author

shobhitchittora commented Nov 15, 2019

@BridgeAR up for review!

doc/api/assert.md Outdated Show resolved Hide resolved
Co-Authored-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
@lpinca
lpinca approved these changes Nov 17, 2019
@lundibundi

This comment has been minimized.

addaleax added a commit that referenced this pull request Nov 18, 2019
Co-Authored-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>

PR-URL: #30483
Refs: #30484
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
@addaleax

This comment has been minimized.

Copy link
Member

addaleax commented Nov 18, 2019

Landed in 5bb4d85 🎉

@addaleax addaleax closed this Nov 18, 2019
BridgeAR added a commit that referenced this pull request Nov 19, 2019
Co-Authored-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>

PR-URL: #30483
Refs: #30484
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Nov 19, 2019
targos added a commit that referenced this pull request Dec 1, 2019
Co-Authored-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>

PR-URL: #30483
Refs: #30484
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 9, 2019
MylesBorins added a commit that referenced this pull request Dec 17, 2019
Co-Authored-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>

PR-URL: #30483
Refs: #30484
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.